[shell] how should we handle 'none' icons in sidebars

[vince-fugnitto]

Description

At the moment, if a user selects none as their file-icon theme and docks editors in the sidepanels, the following occurs:

How should the application handle such a case?

Should we perhaps fallback to a regular file-icon (minimal)?

Steps to Reproduce

1. start the application
2. set the file-icon theme to none
3. open an editor and dock it in the sidebar

Additional Information

• Related Default Icons for (sidepanel) tabs without icon #4616

[lmcbout]

On the same track, how should we handle icons on the side bar for plugins view (i.e. gitlens) ?
To test, install gitlens plugins and select View-> Gitlens
You will see the views, but no icon on the sidebar.
Tested with electron on Ubuntu 16.04 and plugin:gitlens-10.2.0.vsix

[vince-fugnitto]

On the same track, how should we handle icons on the side bar for plugins view (i.e. gitlens) ?
To test, install gitlens plugins and select View-> Gitlens
You will see the views, but no icon on the sidebar.
Tested with electron on Ubuntu 16.04 and plugin:gitlens-10.2.0.vsix

@lmcbout gitlens does add an icon, what is the bug you see?

[lmcbout]

Look at the picture below, This is electron on Ubuntu 16.04, you will see the views from gitlens, but no icon on the side bar except the location where it should be (Right after the "Test:Java icon)

[vince-fugnitto]

Look at the picture below, This is electron on Ubuntu 16.04, you will see the views from gitlens, but no icon on the side bar except the location where it should be (Right after the "Test:Java icon)

Can you open an issue for Electron? (I think it should be tracked separately)
Possibly related to #6834

[akosyakov]

Let’s pick some default icon and use it as a placeholder in such cases.

[akosyakov]

I think we should back to the file icon which comes together with core, i.e. from File Icons (Theia).