Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use icons for vertical tabs ? Like Files/Git/Extensions #716

Closed
hexa00 opened this issue Oct 23, 2017 · 2 comments
Closed

Use icons for vertical tabs ? Like Files/Git/Extensions #716

hexa00 opened this issue Oct 23, 2017 · 2 comments
Labels
enhancement issues that are enhancements to current functionality - nice to haves

Comments

@hexa00
Copy link

hexa00 commented Oct 23, 2017

Should we use icons for these ?

It would look nicer and take less space.

@kittaakos kittaakos added the enhancement issues that are enhancements to current functionality - nice to haves label Oct 24, 2017
@kittaakos kittaakos changed the title Use icons for vertial tabs ? Like FIles/Git/Extensions Use icons for vertical tabs ? Like Files/Git/Extensions Nov 6, 2017
@spoenemann
Copy link
Contributor

spoenemann commented Mar 1, 2018

I already prepared the CSS and TS code to enable this. Using icons in the side bars can be enabled by changing the display property of .p-TabBar.theia-app-sides .p-TabBar-tabIcon in sidepanel.css.

Of course that makes sense only if the widgets have icons. Currently Files, Git and Extensions have no icon.

@svenefftinge
Copy link
Contributor

The recently introduced toolbar contributions are very useful and it is somehow odd, that we don't show them for widgets attached to the side panels (because we don't know where to render them).
If we go with the VS Code way, of having Icons in the vertical tabs, a hover showing the full label and a first row with the label followed by the tool bar icons this would be solved. Given that people have asked for the icon option over time, we might just go down that path and make it the default.

TLDR: Let's make vertical tabs showing the icons and add a first header row to all widgets, where the toolbar is shown on the right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement issues that are enhancements to current functionality - nice to haves
Projects
None yet
Development

No branches or pull requests

4 participants