Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codicons are not rendered when filtering in quick pick #7429

Closed
RomanNikitenko opened this issue Mar 26, 2020 · 1 comment
Closed

Codicons are not rendered when filtering in quick pick #7429

RomanNikitenko opened this issue Mar 26, 2020 · 1 comment
Labels
bug bugs found in the application monaco issues related to monaco

Comments

@RomanNikitenko
Copy link
Contributor

RomanNikitenko commented Mar 26, 2020

Description

We are getting codicons support within Monaco upgrade to 0.19.3: #7149
codicons are rendered correctly for the most use cases.

To face with the bug a few conditions should be met:

  • quick pick
  • filtering
  • codicon variable contains filtering word

So you never face with the bug if you filter branch or create and a codicon is $(plus).

I can see the same behavior for Monaco Playground:
mon_playg

Reproduction Steps

I can reproduce it using git VS Code extension:

  • turned off @theia/git here
  • add vscode-git-1.3.0.1.vsix into the plugins folder.
  • use Git: Checkout to command
  • try to filter by plus word

I understand that it's bad example, but it's good for testing goals.
I think all extensions with codicons will be affected and the better example if you have item with $(link) Open Link label and word for filtering is link.

git_checkout

@RomanNikitenko RomanNikitenko added the bug bugs found in the application label Mar 26, 2020
@RomanNikitenko RomanNikitenko added the monaco issues related to monaco label Mar 26, 2020
@vince-fugnitto
Copy link
Member

I believe the issue is resolved, please re-open if it is not the case:

git-codicon.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application monaco issues related to monaco
Projects
None yet
Development

No branches or pull requests

2 participants