Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All Files filter option throws error #8072

Closed
colin-grant-work opened this issue Jun 22, 2020 · 2 comments · Fixed by #8073
Closed

All Files filter option throws error #8072

colin-grant-work opened this issue Jun 22, 2020 · 2 comments · Fixed by #8073
Labels
bug bugs found in the application file dialog issues related to the file dialog help wanted issues meant to be picked up, require help

Comments

@colin-grant-work
Copy link
Contributor

colin-grant-work commented Jun 22, 2020

Bug Description:

When a file dialog is open that includes a filter field, selecting All Files will throw an error in the console.

Steps to Reproduce:

  1. Start Theia on master in a browser.
  2. Select File menu -> Open Workspace
  3. At the bottom of the file picker, select one of the filter options
  4. Then select the All Files filter option
  5. Observe that an error about .slice of undefined is thrown.

I'll create a PR to fix this in a moment.

Additional Information

  • Operating System: REL7
  • Theia Version: Current master
@akosyakov akosyakov added bug bugs found in the application file dialog issues related to the file dialog help wanted issues meant to be picked up, require help labels Jun 23, 2020
@vince-fugnitto
Copy link
Member

I was able to reproduce 😃

react-dom.development.js:327 Uncaught TypeError: Cannot read property 'slice' of undefined
    at FileDialogTree.push.../../packages/filesystem/lib/browser/file-dialog/file-dialog-tree.js.FileDialogTree.setFilter (file-dialog-tree.ts:36)
    at FileDialogTreeFiltersRenderer.push.../../packages/filesystem/lib/browser/file-dialog/file-dialog-tree-filters-renderer.js.FileDialogTreeFiltersRenderer.onFilterChanged (file-dialog-tree-filters-renderer.tsx:71)
    at FileDialogTreeFiltersRenderer._this.handleFilterChanged (file-dialog-tree-filters-renderer.tsx:46)
    at HTMLUnknownElement.callCallback (react-dom.development.js:188)
    at Object.invokeGuardedCallbackDev (react-dom.development.js:237)
    at invokeGuardedCallback (react-dom.development.js:292)
    at invokeGuardedCallbackAndCatchFirstError (react-dom.development.js:306)
    at executeDispatch (react-dom.development.js:389)
    at executeDispatchesInOrder (react-dom.development.js:414)
    at executeDispatchesAndRelease (react-dom.development.js:3278)

@colin-grant-work
Copy link
Contributor Author

Unusual to get a smiley face for an error 🐛 😸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application file dialog issues related to the file dialog help wanted issues meant to be picked up, require help
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants