Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "theia" and "vscode" contributed API's #8142

Open
tsmaeder opened this issue Jul 6, 2020 · 2 comments
Open

Make "theia" and "vscode" contributed API's #8142

tsmaeder opened this issue Jul 6, 2020 · 2 comments
Labels
enhancement issues that are enhancements to current functionality - nice to haves plug-in system issues related to the plug-in system

Comments

@tsmaeder
Copy link
Contributor

tsmaeder commented Jul 6, 2020

Currently, the theia and vscode API namespaces are special in that they are not contributed via the ExtPluginApiProvider contribution point, but hard-wired in.
I think it would make the code easier to understand if we contributed those API namespaces just like any other API extensions.
Also, it would make sure third-party API have everything needed (currently, initialization protocol is different, so there is some stuff you might not be able to do in a contributed API).
Thirdly, we could separate plugin-ext and plugin-ext theia, thus further separating concerns and aiding understanding.

@tsmaeder tsmaeder added enhancement issues that are enhancements to current functionality - nice to haves plug-in system issues related to the plug-in system labels Jul 6, 2020
@tsmaeder
Copy link
Contributor Author

As a further plus, plugins could use both the vscode and the theia namespaces at the same time, which is not possible at this time. There has been discussions about the theia namespace just containing API that is not the same as vscode API.

@Pines-Cheng
Copy link

The PR seems like still not merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement issues that are enhancements to current functionality - nice to haves plug-in system issues related to the plug-in system
Projects
None yet
Development

No branches or pull requests

2 participants