Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SelectAll/Copy/Paste Keyboard Shortcuts are not working within DevTools and native input and file dialogs #8654

Closed
christlee1989 opened this issue Oct 21, 2020 · 8 comments · Fixed by #8943
Labels
bug bugs found in the application electron issues related to the electron target

Comments

@christlee1989
Copy link

Bug Description:

Copy/Paste Keyboard Shortcuts are not working within DevTools

Steps to Reproduce:

1.Open Devtools
2.try Cmd+C/Cmd+V copy/paste anything in Devtools, Nothing happened

I can see that it executed the COPY command, but nothing todo
image

Additional Information

  • Operating System: macOS 10.15.6
  • Theia Version: 1.6.0
@vince-fugnitto vince-fugnitto added the 🤔 needs more info issues that require more info from the author label Oct 21, 2020
@vince-fugnitto
Copy link
Member

@christlee1989 I'm not sure I understand correctly, are you stating that keyboard shortcuts from the application are not working in chrome's devtools? "Copy/Paste Keyboard Shortcuts are not working within DevTools" seems to suggest this is what the issue is talking about.

@christlee1989
Copy link
Author

@christlee1989 I'm not sure I understand correctly, are you stating that keyboard shortcuts from the application are not working in chrome's devtools? "Copy/Paste Keyboard Shortcuts are not working within DevTools" seems to suggest this is what the issue is talking about.

yes, as shown in the figure

image

@vince-fugnitto
Copy link
Member

@christlee1989 it is still not clear what the exact issue is, commands from theia should not work in devTools, and the standard copy & paste work well in devTools.

@kittaakos
Copy link
Contributor

Where exactly do you have the issues with copy/paster, @christlee1989? Can you share a screencast that depicts the defect?

@kittaakos kittaakos added contributor experience issues related to the contributor experience electron issues related to the electron target and removed 🤔 needs more info issues that require more info from the author labels Oct 28, 2020
@christlee1989
Copy link
Author

commands from theia should not work in devTools, and the standard copy & paste work well in devTools.

When I execute the CMD+C shortcut in devtool, the copy command of theia is triggered,and can’t paste copied content

@kittaakos
Copy link
Contributor

the copy command of theia is triggered

Yes, I can confirm this. It isn't an enjoyable dev experience, especially when you have another (non-theia) Electron browser window opened; keybindings just does not work. For example, for logging in, you open a new browser window.

For the record, this is a dev thing only. It does not cause any core-Theia malfunction. Feel free providing a PR with the fix, @christlee1989 ;)

@kittaakos kittaakos added bug bugs found in the application and removed contributor experience issues related to the contributor experience labels Nov 5, 2020
@kittaakos
Copy link
Contributor

I have converted this issue into a bug: the SelectAll + Copy + Paste functionality does not work with the native dialogs either.

@kittaakos kittaakos changed the title Copy/Paste Keyboard Shortcuts are not working within DevTools Copy/Paste Keyboard Shortcuts are not working within DevTools and native dialogs Nov 5, 2020
@kittaakos kittaakos changed the title Copy/Paste Keyboard Shortcuts are not working within DevTools and native dialogs SelectAll/Copy/Paste Keyboard Shortcuts are not working within DevTools and native input and file dialogs Nov 5, 2020
@zhaomenghuan
Copy link
Contributor

@kittaakos Hello,I also encountered this problem here,is there any solution to this problem?

zhaomenghuan added a commit to zhaomenghuan/theia that referenced this issue Jan 13, 2021
… working within DevTools and native input and file dialogs

Signed-off-by: 赵梦欢 <zhaomenghuan02@meituan.com>
zhaomenghuan added a commit to zhaomenghuan/theia that referenced this issue Feb 18, 2021
… working within DevTools and native input and file dialogs

Signed-off-by: 赵梦欢 <zhaomenghuan02@meituan.com>
kittaakos pushed a commit that referenced this issue Feb 18, 2021
…in DevTools and native input and file dialogs

Signed-off-by: 赵梦欢 <zhaomenghuan02@meituan.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application electron issues related to the electron target
Projects
None yet
4 participants