-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
file-search: support whitespace queries #8747
Labels
enhancement
issues that are enhancements to current functionality - nice to haves
file search
issues related to the file search
Comments
vince-fugnitto
added
enhancement
issues that are enhancements to current functionality - nice to haves
file search
issues related to the file search
labels
Nov 12, 2020
seantan22
pushed a commit
to seantan22/theia
that referenced
this issue
Jan 25, 2021
What it Does Fixes [eclipse-theia#8747](eclipse-theia#8747) - Allows whitespaces to be included in a `quick file open` search query. - Performs both an exact and fuzzy search on the query with whitespaces. How to Test 1. `ctrl + p` to `quick file open` 2. Search for a file with a query that includes whitespaces (eg. `readme core`) 3. Observe that whitespaces do not affect the search results Signed-off-by: seantan22 <sean.a.tan@ericsson.com>
1 task
seantan22
pushed a commit
to seantan22/theia
that referenced
this issue
Jan 25, 2021
What it Does Fixes [eclipse-theia#8747](eclipse-theia#8747) - Allows whitespaces to be included in a `quick file open` search query. - Performs both an exact and fuzzy search on the query with whitespaces. How to Test 1. `ctrl + p` to `quick file open` 2. Search for a file with a query that includes whitespaces (eg. `readme core`) 3. Observe that whitespaces do not affect the search results Signed-off-by: seantan22 <sean.a.tan@ericsson.com>
seantan22
pushed a commit
to seantan22/theia
that referenced
this issue
Jan 26, 2021
What it Does Fixes [eclipse-theia#8747](eclipse-theia#8747) - Allows whitespaces to be included in a `quick file open` search query. - Performs both an exact and fuzzy search on the query with whitespaces. - Adds test for whitespace queries How to Test 1. `ctrl + p` to `quick file open` 2. Search for a file with a query that includes whitespaces (eg. `readme core`) 3. Observe that whitespaces do not affect the search results Signed-off-by: seantan22 <sean.a.tan@ericsson.com>
seantan22
pushed a commit
to seantan22/theia
that referenced
this issue
Jan 26, 2021
What it Does Fixes [eclipse-theia#8747](eclipse-theia#8747) - Allows whitespaces to be included in a `quick file open` search query. - Performs both an exact and fuzzy search on the query with whitespaces. - Adds tests for whitespace queries (considers fuzzy matching and search term order) How to Test 1. `ctrl + p` to `quick file open` 2. Search for a file with a query that includes whitespaces (eg. `readme core`) 3. Observe that whitespaces do not affect the search results (or run `@theia/file-search` tests) Signed-off-by: seantan22 <sean.a.tan@ericsson.com>
seantan22
pushed a commit
to seantan22/theia
that referenced
this issue
Jan 26, 2021
What it Does Fixes [eclipse-theia#8747](eclipse-theia#8747) - Allows whitespaces to be included in a `quick file open` search query. - Performs both an exact and fuzzy search on the query with whitespaces. - Adds tests for whitespace queries (considers fuzzy matching and search term order) How to Test 1. `ctrl + p` to `quick file open` 2. Search for a file with a query that includes whitespaces (eg. `readme core`) 3. Observe that whitespaces do not affect the search results (or run `@theia/file-search` tests) Signed-off-by: seantan22 <sean.a.tan@ericsson.com>
seantan22
pushed a commit
to seantan22/theia
that referenced
this issue
Jan 26, 2021
What it Does Fixes [eclipse-theia#8747](eclipse-theia#8747) - Allows whitespaces to be included in a `quick file open` search query. - Performs both an exact and fuzzy search on the query with whitespaces. - Adds tests for whitespace queries (considers fuzzy matching and search term order) How to Test 1. `ctrl + p` to `quick file open` 2. Search for a file with a query that includes whitespaces (eg. `readme core`) 3. Observe that whitespaces do not affect the search results Alternatively, run `@theia/file-search` tests. Signed-off-by: seantan22 <sean.a.tan@ericsson.com>
seantan22
pushed a commit
to seantan22/theia
that referenced
this issue
Jan 26, 2021
What it Does Fixes [eclipse-theia#8747](eclipse-theia#8747) - Allows whitespaces to be included in a `quick file open` search query. - Performs both an exact and fuzzy search on the query with whitespaces. - Adds tests for whitespace queries (considers fuzzy matching and search term order) How to Test 1. `ctrl + p` to `quick file open` 2. Search for a file with a query that includes whitespaces (eg. `readme core`) 3. Observe that whitespaces do not affect the search results Alternatively, run `@theia/file-search` tests. Signed-off-by: seantan22 <sean.a.tan@ericsson.com>
seantan22
pushed a commit
to seantan22/theia
that referenced
this issue
Jan 26, 2021
What it Does Fixes [eclipse-theia#8747](eclipse-theia#8747) - Allows whitespaces to be included in a `quick file open` search query. - Performs both an exact and fuzzy search on the query with whitespaces. - Adds tests for whitespace queries (considers fuzzy matching and search term order) How to Test 1. `ctrl + p` to `quick file open` 2. Search for a file with a query that includes whitespaces (eg. `readme core`) 3. Observe that whitespaces do not affect the search results Alternatively, run `@theia/file-search` tests. Signed-off-by: seantan22 <sean.a.tan@ericsson.com>
seantan22
pushed a commit
to seantan22/theia
that referenced
this issue
Jan 26, 2021
What it Does Fixes [eclipse-theia#8747](eclipse-theia#8747) - Allows whitespaces to be included in a `quick file open` search query. - Performs both an exact and fuzzy search on the query with whitespaces. - Adds tests for whitespace queries (considers fuzzy matching and search term order) How to Test 1. `ctrl + p` to `quick file open` 2. Search for a file with a query that includes whitespaces (eg. `readme core`) 3. Observe that whitespaces do not affect the search results Alternatively, run `@theia/file-search` tests. Signed-off-by: seantan22 <sean.a.tan@ericsson.com>
seantan22
pushed a commit
to seantan22/theia
that referenced
this issue
Jan 26, 2021
What it Does Fixes [eclipse-theia#8747](eclipse-theia#8747) - Allows whitespaces to be included in a `quick file open` search query. - Performs both an exact and fuzzy search on the query with whitespaces. - Adds tests for whitespace queries (considers fuzzy matching and search term order) How to Test 1. `ctrl + p` to `quick file open` 2. Search for a file with a query that includes whitespaces (eg. `readme core`) 3. Observe that whitespaces do not affect the search results Alternatively, run `@theia/file-search` tests. Signed-off-by: seantan22 <sean.a.tan@ericsson.com>
seantan22
pushed a commit
to seantan22/theia
that referenced
this issue
Jan 26, 2021
What it Does Fixes [eclipse-theia#8747](eclipse-theia#8747) - Allows whitespaces to be included in a `quick file open` search query. - Performs both an exact and fuzzy search on the query with whitespaces. - Adds tests for whitespace queries (considers fuzzy matching and search term order). How to Test 1. `ctrl + p` to `quick file open` 2. Search for a file with a query that includes whitespaces (eg. `readme core`) 3. Observe that whitespaces do not affect the search results Alternatively, run `@theia/file-search` tests. Signed-off-by: seantan22 <sean.a.tan@ericsson.com>
1 task
seantan22
pushed a commit
to seantan22/theia
that referenced
this issue
Jan 27, 2021
What it Does Fixes [eclipse-theia#8747](eclipse-theia#8747) - Allows whitespaces to be included in a `quick file open` search query. - Performs both an exact and fuzzy search on the query with whitespaces. - Adds tests for whitespace queries (considers fuzzy matching and search term order). How to Test 1. `ctrl + p` to `quick file open` 2. Search for a file with a query that includes whitespaces (eg. `readme core`) 3. Observe that whitespaces do not affect the search results Alternatively, run `@theia/file-search` tests. Signed-off-by: seantan22 <sean.a.tan@ericsson.com>
seantan22
pushed a commit
to seantan22/theia
that referenced
this issue
Jan 27, 2021
What it Does Fixes [eclipse-theia#8747](eclipse-theia#8747) - Allows whitespaces to be included in a `quick file open` search query. - Performs both an exact and fuzzy search on the query with whitespaces. - Adds tests for whitespace queries (considers fuzzy matching and search term order). How to Test 1. `ctrl + p` to `quick file open` 2. Search for a file with a query that includes whitespaces (eg. `readme core`) 3. Observe that whitespaces do not affect the search results Alternatively, run `@theia/file-search` tests. Signed-off-by: seantan22 <sean.a.tan@ericsson.com>
seantan22
pushed a commit
to seantan22/theia
that referenced
this issue
Jan 27, 2021
What it Does Fixes [eclipse-theia#8747](eclipse-theia#8747) - Allows whitespaces to be included in a `quick file open` search query. - Adds support for whitespaces in the scoring of file search results - Adds tests for whitespace queries (considers fuzzy matching and search term order). How to Test 1. `ctrl + p` to `quick file open` 2. Search for a file with a query that includes whitespaces (eg. `readme core`) 3. Observe that whitespaces do not affect the search results Alternatively, run `@theia/file-search` tests. Signed-off-by: seantan22 <sean.a.tan@ericsson.com>
seantan22
pushed a commit
to seantan22/theia
that referenced
this issue
Jan 27, 2021
What it Does Fixes [eclipse-theia#8747](eclipse-theia#8747) - Allows whitespaces to be included in a `quick file open` search query. - Adds support for whitespaces in the scoring of file search results - Adds tests for whitespace queries (considers fuzzy matching and search term order). How to Test 1. `ctrl + p` to `quick file open` 2. Search for a file with a query that includes whitespaces (eg. `readme core`) 3. Observe that whitespaces do not affect the search results Alternatively, run `@theia/file-search` tests. Signed-off-by: seantan22 <sean.a.tan@ericsson.com>
seantan22
pushed a commit
to seantan22/theia
that referenced
this issue
Jan 27, 2021
What it Does Fixes [eclipse-theia#8747](eclipse-theia#8747) - Allows whitespaces to be included in a `quick file open` search query. - Adds support for whitespaces in the scoring of file search results - Adds tests for whitespace queries (considers fuzzy matching and search term order). How to Test 1. `ctrl + p` to `quick file open` 2. Search for a file with a query that includes whitespaces (eg. `readme core`) 3. Observe that whitespaces do not affect the search results Alternatively, run `@theia/file-search` tests. Signed-off-by: seantan22 <sean.a.tan@ericsson.com>
seantan22
pushed a commit
to seantan22/theia
that referenced
this issue
Jan 27, 2021
What it Does Fixes [eclipse-theia#8747](eclipse-theia#8747) - Allows whitespaces to be included in a `quick file open` search query. - Adds support for whitespaces in the scoring of file search results - Adds tests for whitespace queries (considers fuzzy matching and search term order). How to Test 1. `ctrl + p` to `quick file open` 2. Search for a file with a query that includes whitespaces (eg. `readme core`) 3. Observe that whitespaces do not affect the search results Alternatively, run `@theia/file-search` tests. Signed-off-by: seantan22 <sean.a.tan@ericsson.com>
seantan22
pushed a commit
to seantan22/theia
that referenced
this issue
Jan 28, 2021
What it Does Fixes [eclipse-theia#8747](eclipse-theia#8747) - Allows whitespaces to be included in a `quick file open` search query. - Adds support for whitespaces in the scoring of file search results - Adds tests for whitespace queries (considers fuzzy matching and search term order). How to Test 1. `ctrl + p` to `quick file open` 2. Search for a file with a query that includes whitespaces (eg. `readme core`) 3. Observe that whitespaces do not affect the search results Alternatively, run `@theia/file-search` tests. Signed-off-by: seantan22 <sean.a.tan@ericsson.com>
seantan22
pushed a commit
to seantan22/theia
that referenced
this issue
Jan 29, 2021
What it Does Fixes [eclipse-theia#8747](eclipse-theia#8747) - Allows whitespaces to be included in a `quick file open` search query. - Adds support for whitespaces in the scoring of file search results - Adds tests for whitespace queries (considers fuzzy matching and search term order). How to Test 1. `ctrl + p` to `quick file open` 2. Search for a file with a query that includes whitespaces (eg. `readme core`) 3. Observe that whitespaces do not affect the search results Alternatively, run `@theia/file-search` tests. Signed-off-by: seantan22 <sean.a.tan@ericsson.com>
seantan22
pushed a commit
to seantan22/theia
that referenced
this issue
Feb 2, 2021
What it Does Fixes [eclipse-theia#8747](eclipse-theia#8747) - Allows whitespaces to be included in a `quick file open` search query. - Adds support for whitespaces in the scoring of file search results - Adds tests for whitespace queries (considers fuzzy matching and search term order). How to Test 1. `ctrl + p` to `quick file open` 2. Search for a file with a query that includes whitespaces (eg. `readme core`) 3. Observe that whitespaces do not affect the search results Alternatively, run `@theia/file-search` tests. Signed-off-by: seantan22 <sean.a.tan@ericsson.com>
seantan22
pushed a commit
to seantan22/theia
that referenced
this issue
Feb 2, 2021
What it Does Fixes [eclipse-theia#8747](eclipse-theia#8747) - Allows whitespaces to be included in a `quick file open` search query. - Adds support for whitespaces in the scoring of file search results - Adds tests for whitespace queries (considers fuzzy matching and search term order). How to Test 1. `ctrl + p` to `quick file open` 2. Search for a file with a query that includes whitespaces (eg. `readme core`) 3. Observe that whitespaces do not affect the search results Alternatively, run `@theia/file-search` tests. Signed-off-by: seantan22 <sean.a.tan@ericsson.com>
seantan22
pushed a commit
to seantan22/theia
that referenced
this issue
Feb 2, 2021
What it Does Fixes [eclipse-theia#8747](eclipse-theia#8747) - Allows whitespaces to be included in a `quick file open` search query. - Adds support for whitespaces in the scoring of file search results - Adds tests for whitespace queries (considers fuzzy matching and search term order). How to Test 1. `ctrl + p` to `quick file open` 2. Search for a file with a query that includes whitespaces (eg. `readme core`) 3. Observe that whitespaces do not affect the search results Alternatively, run `@theia/file-search` tests. Signed-off-by: seantan22 <sean.a.tan@ericsson.com>
vince-fugnitto
pushed a commit
that referenced
this issue
Feb 5, 2021
What it Does Fixes [#8747](#8747) - Allows whitespaces to be included in a `quick file open` search query. - Adds support for whitespaces in the scoring of file search results - Adds tests for whitespace queries (considers fuzzy matching and search term order). How to Test 1. `ctrl + p` to `quick file open` 2. Search for a file with a query that includes whitespaces (eg. `readme core`) 3. Observe that whitespaces do not affect the search results Alternatively, run `@theia/file-search` tests. Signed-off-by: seantan22 <sean.a.tan@ericsson.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
issues that are enhancements to current functionality - nice to haves
file search
issues related to the file search
Feature Description:
The goal is to support queries with whitespaces when searching for files using the
quick file open
.This will allow end-users to search more easily for specific files, for example the query
'readme core'
:Theia
VS Code
The text was updated successfully, but these errors were encountered: