Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scm: add support for strikeThrough #11999

Merged
merged 1 commit into from
Dec 20, 2022
Merged

Conversation

vince-fugnitto
Copy link
Member

What it does

The pull-request adds support for strikethrough decorations for the scm-view for both our internal @theia/git extension and source-control-provider plugins. The changes include modifying our internal @theia/git extension to mark DELETED resources with a strikethough (line-through).

How to test

@theia/git:

image

  1. start the application with a workspace under version control
  2. perform changes in the workspace including adding new files, modifying existing files and deleting files
  3. confirm that the deleted files are decorated with a strikethrough

vscode.git builtin:

image

  1. remove @theia/git from the example application(s)
  2. include the custom vscode.git and vscode.git-base builtins git-builtins.zip (these builtins are modified to include the strikethrough on all resources)
  3. start the application with a workspace under version control
  4. perform changes in the workspace including adding new files, modifying existing files and deleting files
  5. confirm that all resources are decorated with a strikethrough

Review checklist

Reminder for reviewers

The commit adds support for `strikeThrough` decorations for scm-nodes
which have been deleted.

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
@vince-fugnitto vince-fugnitto added git issues related to git vscode issues related to VSCode compatibility scm issues related to the source control manager labels Dec 15, 2022
@vince-fugnitto vince-fugnitto self-assigned this Dec 15, 2022
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@vince-fugnitto
Copy link
Member Author

I'll merge this one after 1.33.0.

@vince-fugnitto vince-fugnitto merged commit ea66bc3 into master Dec 20, 2022
@vince-fugnitto vince-fugnitto deleted the vf/scm-strikeThrough branch December 20, 2022 20:12
@github-actions github-actions bot added this to the 1.34.0 milestone Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
git issues related to git scm issues related to the source control manager vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants