Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added static RefactorMove to CodeActionKind #12039

Conversation

jonah-iden
Copy link
Contributor

@jonah-iden jonah-iden commented Jan 4, 2023

Signed-off-by: Jonah Iden jonah.iden@typefox.io

What it does

This fixes issue #12021

This PR adds a new static field RefactorKind to CodeActionKind according to the vscode api.

i hope i didn't overlooI any mor implementation for it. Though i couldn't find any more this static field itself in the vscode source.

How to test

create local vscode plugin for theia and see that new Field is available.

Review checklist

Reminder for reviewers

refactor.move code action

Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
@jonah-iden jonah-iden changed the title Jiden/vscode-extension-RefactorMove-12021 Added static RefactorMove to CodeActionKind Jan 4, 2023
@JonasHelming JonasHelming added the vscode issues related to VSCode compatibility label Jan 4, 2023
Copy link
Member

@paul-marechal paul-marechal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@paul-marechal paul-marechal merged commit d6b6123 into eclipse-theia:master Jan 5, 2023
@paul-marechal paul-marechal added this to the 1.34.0 milestone Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants