[scripts] Fixed the comparison of package references #12122
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
If there are some dependencies in the package.json but developer forgot to add them into the
references
array of the tsconfig.json, thecompile:references
will not add these dependencies into the tsconfig.json. This can lead to build failures due to errors in the compile order of the modules at build time.I think we should add a check instead of requiring developers to ensure references in tsconfig.json are written correctly. So, I added
expectedReferences.some((reference, index) => currentReferences[index] !== reference)
to fix the generation of the tsconfig.jsonHow to test
Run
yarn compile:references
Review checklist
Reminder for reviewers