Show command shortcuts in toolbar item tooltips.

[tsmaeder]

What it does

Shows the active shortcuts for commands in view toolbars, etc. and on rows in contributed tree views. The linked issue has more discussion about the limitations of the implementation here: #12656 (comment)

Fixes #12656

Contributed on behalf of STMicroelectronics

How to test

The attached plugin contributes a view "Test View Drag and Drop" with a "Print Selection" command in both the view toolbar and on each tree item. There is also a "Toggle enablement" command that toggles the enablePrintSelection context key on and off. While toggling enablement on and off, make sure the correct shortcut is shown 1. in the view toolbar 2. in the global toolbar (you'll have to add the "Print Selection" command manually) and on the individual tree items in the view. You can play with the keybindings in the keymaps.json file (open via the keybindings preference page). For example like so:

{
    "command": "treeViewDnD.printSelection",
    "keybinding": "ctrl+h",
    "when": "!enablePrintSelection"
},
{
    "command": "-treeViewDnD.printSelection",
    "keybinding": "ctrl+o",
    "when": "enablePrintSelection"
}

Review checklist

• As an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• As a reviewer, I agree to behave in accordance with the review guidelines

[msujew]

@tsmaeder Where is the attached plugin? I haven't found it under any link in this PR or the linked issue.

[tsmaeder]

@msujew 🤦

[tsmaeder]

Here's the *.vsix:

custom-view-samples-0.0.1.zip

and the source:_

tree-view-sample.zip

[msujew]

Looks good to me 👍

• Keybindings are shown in the tabbar toolbars
• Keybindings are shown in tree view command items
• All items are updated as expected when context keys or keybindings change