getting-started: fixed open folder link
#12857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit updates the `open folder` link when no recent workspaces are present to prompt users to open a folder instead of a workspace file. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto
added
the
getting-started
vladarama
approved these changes
Aug 23, 2023
marcdumais-work
approved these changes
Aug 31, 2023
This was referenced Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
The pull-request fixes a bug where the getting-started page prompted users to select a workspace file instead of a workspace folder when triggering the
open folderlink when no recent workspaces are present.How to test
rm ~/.theia/recentworkspace.json)getting-started(welcome) pagerecentlist, selectopen a folderReview checklist
Reminder for reviewers