Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary try-catch from RpcProtocol #12961

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Remove unnecessary try-catch from RpcProtocol #12961

merged 1 commit into from
Oct 10, 2023

Conversation

tortmayr
Copy link
Contributor

What it does

Removes unnecessary try-catch that just rethrows the error from RpcProtocol.handleReplyError.

How to test

Only a code style change, should not affect functionality.

Follow-ups

Review checklist

Reminder for reviewers

@tortmayr tortmayr requested a review from tsmaeder October 9, 2023 12:34
tsmaeder
tsmaeder approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@tsmaeder tsmaeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not even I can find fault with that :-)

@tortmayr tortmayr merged commit 3e9d593 into eclipse-theia:master Oct 10, 2023
12 checks passed
@tortmayr tortmayr deleted the minor-fix branch October 10, 2023 07:49
@vince-fugnitto vince-fugnitto added this to the 1.43.0 milestone Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsmaeder tsmaeder tsmaeder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
PR Backlog
Archived in project
Milestone
1.43.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tortmayr @tsmaeder @vince-fugnitto