Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve terminalQuickFixProvider stubbed API with vscode 1.85 #13240

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

rschnekenbu
Copy link
Contributor

What it does

This PR updates the proposed API for terminalQuickFixProvider, that was updated in vscode 1.85. This API is currently stubbed, so this will not change any behavior

Fixes #13234

Contributed on behalf of STMicroelectronics

How to test

There should be no runtime changes compared to master, as the API is only stubbed. The npm builtin extension depends on this interface, it should still install and run on 1.85 version.

Follow-ups

no follow up.

Review checklist

Reminder for reviewers

Contributed on behalf of STMicroelectronics

Signed-off-by: Remi Schnekenburger <rschnekenburger@eclipsesource.com>
Copy link
Contributor

@tsmaeder tsmaeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes seems trivial and the npm view still comes up fine.

@tsmaeder tsmaeder merged commit 38756d6 into eclipse-theia:master Jan 15, 2024
14 checks passed
@jfaltermeier jfaltermeier added this to the 1.46.0 milestone Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[vscode] improve proposed API terminalQuickFixProvider in vscode 1.85 (stub implementation)
3 participants