Add keybindings to toggle the tree checkbox #13271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-fleck-at
approved these changes
Jan 16, 2024
There was a problem hiding this comment.
Thank you very much for that change @haydar-metin! Everything looks good to me.
I also tested this with a tree widget (as opposed to tree view widget coming from the VS Code API) and I noticed that the children/parent toggle management does not exist there. Probably that is on purpose since the option is only available for view widgets (see #12836) but I just wanted to note that down somewhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Allows the user to toggle the checkbox on a tree node using the keyboard.
Fixes #13263
How to test
checkbox-keyboard-toggle-0.0.1.zip
https://github.com/haydar-metin/theia-playground/tree/issues/13263
spaceyou can toggle the checkboxThe current behavior of collapsed entires is defined here:
https://github.com/eclipse-theia/theia/blob/master/packages/plugin/src/theia.d.ts#L6055
If the tree item is collapsed by default (meaning that the children haven't yet been fetched) then child checkboxes will not be updated.Follow-ups
Review checklist
Reminder for reviewers