fix: regressions from headless plugins refactoring #13337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commit 9a7a367 restores the forwarding of |
xai
changed the title
- fix gaps and errors in Inversify DI configuration in the web worker for frontend plugins - restore the onDidDeploy() forwarding lost in the refactoring for headless plugins Fixes eclipse-theia#13320 Contributed on behalf of STMicroelectronics Signed-off-by: Olaf Lessenich <olessenich@eclipsesource.com> Co-authored-by: Christian W. Damus <cdamus.ext@eclipsesource.com> Signed-off-by: Christian W. Damus <cdamus.ext@eclipsesource.com>
|
@msujew This fixes a regression, we want to do a patch release with this. A quick review would be great! |
msujew
approved these changes
Feb 1, 2024
jfaltermeier
pushed a commit
that referenced
this pull request
Feb 6, 2024
- fix gaps and errors in Inversify DI configuration in the web worker for frontend plugins - restore the onDidDeploy() forwarding lost in the refactoring for headless plugins Fixes #13320 Contributed on behalf of STMicroelectronics Signed-off-by: Olaf Lessenich <olessenich@eclipsesource.com> Co-authored-by: Christian W. Damus <cdamus.ext@eclipsesource.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13320
Contributed on behalf of STMicroelectronics
What it does
Fixes regressions from headless plugins refactoring (#13320 )
How to test
Follow-ups
Review checklist
Reminder for reviewers