-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
notebook kernel messaging and renderer messaging fixes #13401
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks pretty good. I've confirmed that this works even for pretty complicated widgets such as:
a = widgets.FloatText()
b = widgets.FloatSlider()
display(a,b)
mylink = widgets.jslink((a, 'value'), (b, 'value'))
Before approving, I wanted to ask about this error. Have you seen that one when trying to execute a ipywidgets
cell? If so, do you think it makes sense to fix it or leave it for a separate PR (I'd be fine with it, as it doesn't seem to impact behavior):
Thanks for the review. No, I did not see that fallbackToNextRenderer when testing ipywidgets. |
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
1c7f502
to
91da624
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good to me 👍
What it does
This implements the proposed Kernel messaging API (
vscode.proposed.notebookMessaging.d.ts
) and thenotebookPreload
contribution point. Also fixes notebook renderer messaging. This is to support interactive output widgets like for theipywidgets
library.Tested with ipywidgets 7.8.1 and 8.1.2
How to test
pip install ipywidgets
in your used kernelFollow-ups
Review checklist
Reminder for reviewers