Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only initialize notebook cell editor when in viewport #13476

Merged
merged 4 commits into from
Mar 19, 2024

Conversation

jonah-iden
Copy link
Contributor

What it does

This implements parts of #13015
This optimizes the notebook editor widget so that monaco editors for code cells are only created once they come into the viewport. This should make opening large notbooks quite a bit more performant.

How to test

Open a notebook. Everything should still look the same. You should be able to see in the dom tree that all except the editors in the view are only mock editors with the estimated height of the content

Follow-ups

Review checklist

Reminder for reviewers

@jonah-iden jonah-iden added performance issues related to performance notebook issues related to notebooks labels Mar 11, 2024
@jonah-iden jonah-iden requested a review from jbicker March 13, 2024 09:17
Copy link
Contributor

@jbicker jbicker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The editors are empty after I've reloaded the page and have another editor focused first. When I scroll everything is shown.

notebook-editors-empty.mp4

@jbicker
Copy link
Contributor

jbicker commented Mar 18, 2024

Besides that everything works very fine.

Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
@jonah-iden jonah-iden force-pushed the jiden/notebook-optimzations branch from 2808467 to 0211299 Compare March 19, 2024 10:28
@jonah-iden jonah-iden merged commit 79a3244 into master Mar 19, 2024
14 checks passed
@github-actions github-actions bot added this to the 1.48.0 milestone Mar 19, 2024
@jonah-iden jonah-iden deleted the jiden/notebook-optimzations branch March 19, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notebook issues related to notebooks performance issues related to performance
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants