Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix monaco localization #13557

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Fix monaco localization #13557

merged 1 commit into from
Apr 12, 2024

Conversation

msujew
Copy link
Member

@msujew msujew commented Apr 3, 2024

What it does

Closes #13438
Closes #13556

Moves the monaco localization code into the monaco-init.ts file so that the localization function is overriden before any other monaco code is loaded.

Fixes the automatic install of language packs as a drive-by.

How to test

  1. Change the language of Theia to any other than English.
  2. Open the context menu of a monaco editor. It should be correctly translated

Review checklist

Reminder for reviewers

@msujew msujew added monaco issues related to monaco localization issues related to localization/internalization/nls labels Apr 3, 2024
@msujew msujew requested a review from tsmaeder April 3, 2024 09:54
@msujew
Copy link
Member Author

msujew commented Apr 10, 2024

@tsmaeder ping, it's a small change :)

Copy link
Contributor

@tsmaeder tsmaeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

¡Me gusta!

@msujew msujew merged commit fd5be30 into master Apr 12, 2024
14 checks passed
@msujew msujew deleted the msujew/fix-monaco-localization branch April 12, 2024 14:07
@github-actions github-actions bot added this to the 1.49.0 milestone Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
localization issues related to localization/internalization/nls monaco issues related to monaco
Projects
Archived in project
2 participants