Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix window revealing when navigating with multiple windows #13561

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

tsmaeder
Copy link
Contributor

@tsmaeder tsmaeder commented Apr 3, 2024

What it does

Makes sure the correct window is brought to the top when navigating between editors.

Fixes: #13559

Contributed on behalf of STMicroelectronics

How to test

  1. Follow the scenario from the linked issue and make sure the correct windows is revealed when navigating in both windows
  2. In each Theia window from scenario No. 1, open a file in a secondary window and make sure we can navigate from both the secondary window and the main window and vice-versa.

Follow-ups

Review checklist

Reminder for reviewers

Fixes: eclipse-theia#13559

Contributed on behalf of STMicroelectronics

Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
@tsmaeder tsmaeder requested a review from planger April 3, 2024 13:50
Copy link
Contributor

@planger planger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me! 👍 Confirmed that #13561 applies in Ubuntu Linux and that this PR fixes the bug.

@tsmaeder tsmaeder merged commit 5d653b2 into eclipse-theia:master Apr 4, 2024
14 checks passed
jfaltermeier pushed a commit that referenced this pull request Apr 5, 2024
Fixes: #13559

Contributed on behalf of STMicroelectronics

Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
@jfaltermeier jfaltermeier added this to the 1.49.0 milestone Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Wrong Window Revealed when Navigating in Editor
3 participants