Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reenable initial reading of execution summary #13567

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

jonah-iden
Copy link
Contributor

What it does

It reenables the reading of the execution summary from the deserialized notebook data.
This shows the exectution order (cell numbers) correctly after first opening the notebook

How to test

open or create a new notebook. Execute a cell and check the cell number has been set correctly. Close and reopen the notebook and see the cell number should be set correctly again

Follow-ups

Review checklist

Reminder for reviewers

Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
@jonah-iden jonah-iden requested a review from msujew April 4, 2024 13:26
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well, thanks 👍

@jonah-iden jonah-iden merged commit 09051c4 into master Apr 4, 2024
14 checks passed
@jonah-iden jonah-iden deleted the jiden/reenable-exection-summary branch April 4, 2024 14:17
@github-actions github-actions bot added this to the 1.49.0 milestone Apr 4, 2024
@msujew msujew added the notebook issues related to notebooks label Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notebook issues related to notebooks
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants