-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plugin system breaks user storage abstraction #4488
Comments
The default workspace server uses a hard-coded theia/packages/workspace/src/node/default-workspace-server.ts Lines 165 to 167 in 1eaecd5
|
@kittaakos there is a PR which will handle that too: #6650 |
@mmorhun if it is quite important change for 1.0, since we need Electron running vscode extensions properly. If it takes long please raise it that someone can add additional commits to finish it. You should also be able to open a new PR from your fork in the meantime as a workaround of missing write access. |
@akosyakov I've pinged Eclipse Webmater, so I think in a day or so the issue should be resolved. |
Closes #4488. Signed-off-by: Akos Kitta <kittaakos@typefox.io>
Closes #4488. Signed-off-by: Akos Kitta <kittaakos@typefox.io>
Closes #4488. Signed-off-by: Akos Kitta <kittaakos@typefox.io>
Closes #4488. Signed-off-by: Akos Kitta <kittaakos@typefox.io>
Closes #4488. Signed-off-by: Akos Kitta <kittaakos@typefox.io>
Closes #4488. Signed-off-by: Akos Kitta <kittaakos@typefox.io>
Closes #4488. Signed-off-by: Akos Kitta <kittaakos@typefox.io>
Closes #4488. Signed-off-by: Akos Kitta <kittaakos@typefox.io>
Closes #4488. Signed-off-by: Akos Kitta <kittaakos@typefox.io>
Closes #4488. Signed-off-by: Akos Kitta <kittaakos@typefox.io>
Closes eclipse-theia#4488. Signed-off-by: Akos Kitta <kittaakos@typefox.io>
UserStorageService encapsulates where user data are stored, by default under
.theia
in user home.Plugin system leaks it with own implementation: https://github.com/theia-ide/theia/blob/ad9e62bd78bf4da3ce829b25de64f9aa3fc8aaeb/packages/plugin-ext/src/main/node/paths/plugin-paths-service.ts#L140-L147
The text was updated successfully, but these errors were encountered: