Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin system breaks user storage abstraction #4488

Closed
akosyakov opened this issue Mar 6, 2019 · 4 comments
Closed

plugin system breaks user storage abstraction #4488

akosyakov opened this issue Mar 6, 2019 · 4 comments
Labels
enhancement issues that are enhancements to current functionality - nice to haves plug-in system issues related to the plug-in system

Comments

@akosyakov
Copy link
Member

akosyakov commented Mar 6, 2019

UserStorageService encapsulates where user data are stored, by default under .theia in user home.

Plugin system leaks it with own implementation: https://github.com/theia-ide/theia/blob/ad9e62bd78bf4da3ce829b25de64f9aa3fc8aaeb/packages/plugin-ext/src/main/node/paths/plugin-paths-service.ts#L140-L147

@akosyakov akosyakov added bug bugs found in the application plug-in system issues related to the plug-in system labels Mar 6, 2019
@mmorhun mmorhun self-assigned this Nov 20, 2019
@mmorhun mmorhun added enhancement issues that are enhancements to current functionality - nice to haves and removed bug bugs found in the application labels Nov 21, 2019
@kittaakos
Copy link
Contributor

UserStorageService encapsulates where user data are stored, by default under .theia in user home.

The default workspace server uses a hard-coded .theia path too:

protected getUserStoragePath(): string {
return path.resolve(os.homedir(), '.theia', 'recentworkspace.json');
}

@mmorhun
Copy link
Contributor

mmorhun commented Feb 17, 2020

@kittaakos there is a PR which will handle that too: #6650
I'm going to update it as soon as I regain write access into Theia repository.

@akosyakov
Copy link
Member Author

@mmorhun if it is quite important change for 1.0, since we need Electron running vscode extensions properly. If it takes long please raise it that someone can add additional commits to finish it. You should also be able to open a new PR from your fork in the meantime as a workaround of missing write access.

@mmorhun
Copy link
Contributor

mmorhun commented Feb 17, 2020

@akosyakov I've pinged Eclipse Webmater, so I think in a day or so the issue should be resolved.

kittaakos pushed a commit that referenced this issue Feb 25, 2020
Closes #4488.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
kittaakos pushed a commit that referenced this issue Feb 26, 2020
Closes #4488.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
kittaakos pushed a commit that referenced this issue Feb 26, 2020
Closes #4488.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
kittaakos pushed a commit that referenced this issue Feb 26, 2020
Closes #4488.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
kittaakos pushed a commit that referenced this issue Feb 26, 2020
Closes #4488.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
kittaakos pushed a commit that referenced this issue Feb 26, 2020
Closes #4488.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
kittaakos pushed a commit that referenced this issue Feb 26, 2020
Closes #4488.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
kittaakos pushed a commit that referenced this issue Feb 26, 2020
Closes #4488.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
kittaakos pushed a commit that referenced this issue Feb 26, 2020
Closes #4488.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
kittaakos pushed a commit that referenced this issue Feb 26, 2020
Closes #4488.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
JesterOrNot pushed a commit to JesterOrNot/theia that referenced this issue Mar 12, 2020
Closes eclipse-theia#4488.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement issues that are enhancements to current functionality - nice to haves plug-in system issues related to the plug-in system
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants