Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display source folder name for detected tasks in quick open #5550

Merged
merged 1 commit into from
Jun 21, 2019

Conversation

elaihau
Copy link
Contributor

@elaihau elaihau commented Jun 20, 2019

  • Full paths of source folders are displayed in the detected tasks' list. Only folder name should be displayed.

Signed-off-by: elaihau liang.huang@ericsson.com

- Full paths of source folders are displayed in the detected tasks' list. Only folder name should be displayed.

Signed-off-by: elaihau <liang.huang@ericsson.com>
@elaihau
Copy link
Contributor Author

elaihau commented Jun 20, 2019

See details of the problem in #5313 (comment)

@vince-fugnitto
Copy link
Member

How can I successfully test the PR?
When attempting to add detected tasks in a multi-root workspace, the items would not display, while they did in a single-root workspace.

@RomanNikitenko
Copy link
Contributor

RomanNikitenko commented Jun 21, 2019

I tested the PR and it works fine for me!
The only thing I noticed is we have the same problem for 'Configure Tasks...' menu

Configure items for Theia:
theia_configure

Configure items for VS Code:
vs_code_configure

I think we should do something similar here, maybe in another PR.

@elaihau
Copy link
Contributor Author

elaihau commented Jun 21, 2019

I will merge this one, and fix the "configure task" quick open after #5472 gets merged.

@elaihau elaihau merged commit d5d640b into eclipse-theia:master Jun 21, 2019
@elaihau elaihau deleted the fix_task_desc branch June 21, 2019 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants