Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[preferences] fix indentation when updating preferences through the tree #6736

Merged
merged 1 commit into from
Dec 20, 2019
Merged

[preferences] fix indentation when updating preferences through the tree #6736

merged 1 commit into from
Dec 20, 2019

Commits on Dec 19, 2019

  1. Fix indentation when using preferences tree 

    Fixes #5052

- fixes the indentation when updating/setting a preference using the
`preferences-tree` widget.
- the current implementation had a hardcoded value of `tabSize`=3 and `insertSpaces`=true which
meant that if the `settings.json` file had different formatting, it would insert incorrectly.
- added a new method `getFormattingOptions` which gets the preference options for tabSize and indentation type.
- fixed typings from the `preference-service`. If a default value is provided, the preference should return that
value if the preference initially returns `undefined`.

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
    @vince-fugnitto
    vince-fugnitto committed Dec 19, 2019
    Configuration menu
    Copy the full SHA
    488a5b1 View commit details
    Browse the repository at this point in the history