From a1a6deb20147d81824920e703479b11759ba59ac Mon Sep 17 00:00:00 2001 From: Vincent Fugnitto Date: Thu, 12 Mar 2020 06:17:53 -0400 Subject: [PATCH] terminal: fix color theming Fixes #7280 This commit fixes the issue where VS Code terminal theming was not applied correctly. Since the VS Code theming options for terminals and the `xterm` ITheme differed (lower-case first letter), the terminal themes were not applied properly. Signed-off-by: Vincent Fugnitto --- packages/terminal/src/browser/terminal-theme-service.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/terminal/src/browser/terminal-theme-service.ts b/packages/terminal/src/browser/terminal-theme-service.ts index ed844ecb01bd3..6b7b6cfeb80cc 100644 --- a/packages/terminal/src/browser/terminal-theme-service.ts +++ b/packages/terminal/src/browser/terminal-theme-service.ts @@ -177,7 +177,8 @@ export class TerminalThemeService { }; // eslint-disable-next-line guard-for-in for (const id in terminalAnsiColorMap) { - const colorName = id.substring(13); + const colorId = id.substring(13); + const colorName = colorId.charAt(0).toLowerCase() + colorId.slice(1); // eslint-disable-next-line @typescript-eslint/no-explicit-any (theme as any)[colorName] = this.colorRegistry.getCurrentColor(id); }