From 8d5c1c2a9a1a86c29b5f60f7070d3b0f8ac5cf0f Mon Sep 17 00:00:00 2001 From: Shahar Harari Date: Tue, 12 May 2020 15:57:54 +0300 Subject: [PATCH] Fix: Plugins folders are created with exclamanation mark, which breaks webpack sign commit Signed-off-by: Shahar Harari sign commit Signed-off-by: Shahar Harari --- .../plugin-ext-vscode/src/node/plugin-vscode-file-handler.ts | 2 +- .../src/main/node/handlers/plugin-theia-file-handler.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/plugin-ext-vscode/src/node/plugin-vscode-file-handler.ts b/packages/plugin-ext-vscode/src/node/plugin-vscode-file-handler.ts index 118ff0679ef98..60acac14013a3 100644 --- a/packages/plugin-ext-vscode/src/node/plugin-vscode-file-handler.ts +++ b/packages/plugin-ext-vscode/src/node/plugin-vscode-file-handler.ts @@ -58,7 +58,7 @@ export class PluginVsCodeFileHandler implements PluginDeployerFileHandler { if (context.pluginEntry().type === PluginType.User) { extensionsDirUri = await this.environment.getExtensionsDirUri(); } - return FileUri.fsPath(extensionsDirUri.resolve(filenamify(context.pluginEntry().id()))); + return FileUri.fsPath(extensionsDirUri.resolve(filenamify(context.pluginEntry().id(), { replacement: '_' }))); } protected async decompress(extensionDir: string, context: PluginDeployerFileHandlerContext): Promise { diff --git a/packages/plugin-ext/src/main/node/handlers/plugin-theia-file-handler.ts b/packages/plugin-ext/src/main/node/handlers/plugin-theia-file-handler.ts index 78f7fe1552270..1b28e5ae53585 100644 --- a/packages/plugin-ext/src/main/node/handlers/plugin-theia-file-handler.ts +++ b/packages/plugin-ext/src/main/node/handlers/plugin-theia-file-handler.ts @@ -53,6 +53,6 @@ export class PluginTheiaFileHandler implements PluginDeployerFileHandler { if (context.pluginEntry().type === PluginType.User) { pluginsDirUri = await this.environment.getPluginsDirUri(); } - return FileUri.fsPath(pluginsDirUri.resolve(filenamify(context.pluginEntry().id()))); + return FileUri.fsPath(pluginsDirUri.resolve(filenamify(context.pluginEntry().id(), { replacement: '_' }))); } }