server: Create bookmarks file for experiments #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bookmarks file can be used to store and retrieve markers associated with an experiment using platform APIs. It can later be obtained for an opened experiment with: TmfTraceManager.getInstance().getTraceEditorFile(experiment) Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
MatthewKhouzam
approved these changes
Nov 14, 2024
| final InputStream source = new ByteArrayInputStream(new byte[0]); | ||
| bookmarksFile.create(source, IResource.FORCE | IResource.HIDDEN, new NullProgressMonitor()); | ||
| } | ||
| file.createLink(bookmarksFile.getLocation(), IResource.REPLACE | IResource.HIDDEN, new NullProgressMonitor()); |
There was a problem hiding this comment.
According to createLink() Javadoc, only the mentioned flags have an effect while other flags are ignored, and FORCE is not mentioned.
There was a problem hiding this comment.
Should we update the other one then TmfCommonProjectElement.java:394
There was a problem hiding this comment.
It's handled in create() but ignored in createLink().
PatrickTasse
merged commit 1c6f68b
into
eclipse-tracecompass-incubator:master
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bookmarks file can be used to store and retrieve markers associated with an experiment using platform APIs.
It can later be obtained for an opened experiment with: TmfTraceManager.getInstance().getTraceEditorFile(experiment)