Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAC OSX Incubator version is not working #101

Open
ammarwa opened this issue Jun 7, 2024 · 7 comments
Open

MAC OSX Incubator version is not working #101

ammarwa opened this issue Jun 7, 2024 · 7 comments

Comments

@ammarwa
Copy link

ammarwa commented Jun 7, 2024

If I try to download the incubator version and try to run it on M1 MAC OSX, I will get the following screen:
image

With the normal version, I had to edit the Info.list to check the right Java path on my machine.

Let me know if you need more information.

@bhufmann
Copy link
Contributor

bhufmann commented Jun 7, 2024

The build of incubator RCP doesn't do mac signing and notarization. If you'd like to use the MAC RCP use the Trace Compass mainline RCP build and install the incubator features using the Tools -> Add-ons menu.

The mainline RCP (ending with .dmg) can downloaded from here: https://download.eclipse.org/tracecompass/releases/9.3.0/rcp/

@ammarwa
Copy link
Author

ammarwa commented Jun 11, 2024

How can I add ROCm plugin?

@ammarwa
Copy link
Author

ammarwa commented Jun 11, 2024

with the version you suggested, I still need to edit the contents because of the following error:
image

@arfio
Copy link
Contributor

arfio commented Jun 11, 2024

Would it be easy to add mac signing and notarization for the incubator release as well ?
To add plug-ins in the mainline RCP: https://archive.eclipse.org/tracecompass/doc/stable/org.eclipse.tracecompass.rcp.doc.user/Trace-Compass-Incubator.html

@bhufmann
Copy link
Contributor

It's not that hard because you can follow what was done in Trace Compass mainline. However, some changes need to be done in the pom files and CI setup.

From what I can remember, you will have to add a mac signing and a notarization profile in the RCP product pom.xml. Then add flags to the incubator Jenkinsfile to be enable mac signing. In Trace Compass we have a separate jenkins job that does the notarization (https://ci.eclipse.org/tracecompass/job/notarize-tracecompass-dmgs/) which is triggered after a successful build (e.g. nightly.). It calls a script (notarize-mac.sh) for that.

@arfio
Copy link
Contributor

arfio commented Jun 11, 2024

I will look into it, thank you very much for the explanation !

@MatthewKhouzam
Copy link
Contributor

Hey, as a quick stopgap fix... would this help?

xattr -d com.apple.quarantine /PATH/TO/APPLICATION

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants