Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API cleanup for 10.0.0 #86

Merged
merged 3 commits into from
May 22, 2024

Conversation

PatrickTasse
Copy link
Contributor

@PatrickTasse PatrickTasse commented May 21, 2024

Fixes issue #87

@bhufmann
Copy link
Contributor

@PatrickTasse See https://github.com/eclipse-tracecompass/org.eclipse.tracecompass/blob/master/API_POLICY.md#process-to-remove-deprecated-apis about the steps to do for this task (e.g. open issue ticket, announce on mailing list). Could you please provide these steps? Thanks!

@PatrickTasse PatrickTasse force-pushed the apicleanup branch 2 times, most recently from 86190ed to 44ad40e Compare May 22, 2024 20:23

/**
* Alternate create method for CTF2 integers which have roles
* Create method for CTF2 integers which have roles
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The API on the left was deprecated in September 2023, after the 2023-06 release. So, we cannot remove this API just yet. We can only do it in 2025-06 release.

Deprecated in patch:
https://git.eclipse.org/r/c/tracecompass/org.eclipse.tracecompass/+/182723

Fixes issue eclipse-tracecompass#87

[Removed] OsSystemModel.addWorker(OsWorker)
[Removed] OsSystemModel.findWorker(HostThread)

Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Deprecated in patch:
https://git.eclipse.org/r/c/tracecompass/org.eclipse.tracecompass/+/193127

Fixes issue eclipse-tracecompass#87

[Removed] AbstractSegmentStatisticsAnalysis.getSegmentProviderAnalysis()

Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Deprecated in patch:
https://git.eclipse.org/r/c/tracecompass/org.eclipse.tracecompass/+/182723
https://git.eclipse.org/r/c/tracecompass/org.eclipse.tracecompass/+/192194

Fixes issue eclipse-tracecompass#87

[Removed] ITmfGraphVisitor
[Removed] AbstractTmfGraphBuilderModule.getGraph()
[Removed] AbstractTmfGraphBuilderModule.getCriticalPath()
[Removed] ITmfGraphProvider.assignTargetGraph()
[Removed] ITmfGraphProvider.getAssignedGraph()
[Removed] AbstractTmfGraphProvider.assignTargetGraph()
[Removed] AbstractTmfGraphProvider.getAssignedGraph()
[Removed] AbstractCriticalPathModule.getCriticalPath()
[Removed] ICriticalPathAlgorithm.compute()
[Removed] ICriticalPathProvider.getCriticalPath()
[Removed] TmfEdge
[Removed] TmfGraph
[Removed] TmfVertex
[Removed] CriticalPathModule

Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Copy link
Contributor

@bhufmann bhufmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Tested Critical Path for changed dependency graph code. Still works. Thanks!

@PatrickTasse PatrickTasse merged commit f5c4c28 into eclipse-tracecompass:master May 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants