Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Micrometer configuration lifecycle violation #5268

Closed
jonatan-ivanov opened this issue Aug 1, 2024 · 2 comments
Closed

Micrometer configuration lifecycle violation #5268

jonatan-ivanov opened this issue Aug 1, 2024 · 2 comments

Comments

@jonatan-ivanov
Copy link

jonatan-ivanov commented Aug 1, 2024

Micrometer's MeterRegistry should be "configured" (see MeterRegistry.Config) before registering Meter instances to it. For example MeterFilters should be configured before a Meter has been registered to the registry.

Historically, Micrometer has allowed configuring MeterFilters after meters have been registered but due to certain performance optimizations with micrometer-metrics/micrometer#4917 we took a step toward warning users about this situation.

See:

It seems in certain cases Vert.x configures a MeterFilter after a Meter has been registered to the registry causing the warning mentioned above. See micrometer-metrics/micrometer#4920 (comment) by @sanyarnd with a reproducer.

@sanyarnd could you please provide the Vert.x version you are using and any additional details you have?

@vietj
Copy link
Member

vietj commented Aug 1, 2024

@jonatan-ivanov can you re-create this issue in this repo please ? vert-x3/vertx-micrometer-metrics#202

@vietj vietj closed this as completed Aug 1, 2024
@vietj vietj removed the bug label Aug 1, 2024
@jonatan-ivanov
Copy link
Author

@vietj Of course: vert-x3/vertx-micrometer-metrics#224

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants