Feat: Support running under Node.js #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Slavomir Kucera <slavomir.kucera@broadcom.com>
Signed-off-by: Slavomir Kucera <slavomir.kucera@broadcom.com>
Signed-off-by: Slavomir Kucera <slavomir.kucera@broadcom.com>
Signed-off-by: Slavomir Kucera <slavomir.kucera@broadcom.com>
Signed-off-by: Slavomir Kucera <slavomir.kucera@broadcom.com>
Signed-off-by: Slavomir Kucera <slavomir.kucera@broadcom.com>
Signed-off-by: Slavomir Kucera <slavomir.kucera@broadcom.com>
Signed-off-by: Slavomir Kucera <slavomir.kucera@broadcom.com>
Signed-off-by: Slavomir Kucera <slavomir.kucera@broadcom.com>
Signed-off-by: Slavomir Kucera <slavomir.kucera@broadcom.com>
Signed-off-by: Slavomir Kucera <slavomir.kucera@broadcom.com>
Signed-off-by: Slavomir Kucera <slavomir.kucera@broadcom.com>
Signed-off-by: Slavomir Kucera <slavomir.kucera@broadcom.com>
Signed-off-by: Slavomir Kucera <slavomir.kucera@broadcom.com>
Signed-off-by: Slavomir Kucera <slavomir.kucera@broadcom.com>
Signed-off-by: Slavomir Kucera <slavomir.kucera@broadcom.com>
Signed-off-by: Slavomir Kucera <slavomir.kucera@broadcom.com>
Signed-off-by: Slavomir Kucera <slavomir.kucera@broadcom.com>
Signed-off-by: Slavomir Kucera <slavomir.kucera@broadcom.com>
Signed-off-by: Slavomir Kucera <slavomir.kucera@broadcom.com>
Signed-off-by: Slavomir Kucera <slavomir.kucera@broadcom.com>
Signed-off-by: Slavomir Kucera <slavomir.kucera@broadcom.com>
Signed-off-by: Slavomir Kucera <slavomir.kucera@broadcom.com>
Signed-off-by: Slavomir Kucera <slavomir.kucera@broadcom.com>
Signed-off-by: Slavomir Kucera <slavomir.kucera@broadcom.com>
Signed-off-by: Slavomir Kucera <slavomir.kucera@broadcom.com>
Signed-off-by: Slavomir Kucera <slavomir.kucera@broadcom.com>
| if (platform::is_windows()) | ||
| { | ||
| ws.did_open_file("test\\library\\test_wks\\correct"); | ||
| return std::make_pair(std::make_shared<context::hlasm_context>("test\\library\\test_wks\\correct"), |
There was a problem hiding this comment.
maybe we could use std::filesystem::path("test/library/test_wks/correct").native() in such cases (if path::native is not broken in emscripten)
…p-for-hlasm into emscripten-build
Signed-off-by: Slavomir Kucera <slavomir.kucera@broadcom.com>
Signed-off-by: Slavomir Kucera <slavomir.kucera@broadcom.com>
Signed-off-by: Slavomir Kucera <slavomir.kucera@broadcom.com>
Signed-off-by: Slavomir Kucera <slavomir.kucera@broadcom.com>
Signed-off-by: Slavomir Kucera <slavomir.kucera@broadcom.com>
|
SonarCloud Quality Gate failed. |
michalbali256
approved these changes
Apr 6, 2021
|
🎉 This PR is included in version 0.13.0-beta.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 0.13.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces changes to support build using the Emscripten SDK and introduces extension changes to utilize it. This should help us run in restricted environments like the one described in #96.