fix: Syntax errors reported in bilingual macros #152
Conversation
fix: Language server crashes on an unexpected statement in the lookahead mode.
|
Kudos, SonarCloud Quality Gate passed! |
|
|
||
| ++curr_line_; | ||
| ++curr_line_; // TODO: What are we doing here??? |
There was a problem hiding this comment.
I believe curr_line_ holds index of the current statement in the resulting macro definition
| diagnoser.add_diagnostic(diag); | ||
| if (processor.kind != processing_kind::LOOKAHEAD) | ||
| { | ||
| for (const diagnostic_op& diag : cache_item->diags) |
There was a problem hiding this comment.
Now, that statements are able to hold diagnostics, should we get rid of cache_item->diags and store all the diagnostics directly in the statement instead?
There was a problem hiding this comment.
I think not just yet. Because from what I've observed, there are diagnostics that are printed once (e.g. during macro definition pass) and then there are diagnostics produced for each statement execution.
The current implementation tries to follow the behavior as closely as possible, but I think that we will need further refinement of how we store/replay diagnostics.
|
🎉 This PR is included in version 0.14.0-beta.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 0.14.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
fix: Syntax errors reported in bilingual macros (closes #144)
fix: Language server crashes on missing MEND.