Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Label operand of macros passed as upper case #155

Closed
michalbali256 opened this issue Aug 9, 2021 · 2 comments · Fixed by #165
Closed

Label operand of macros passed as upper case #155

michalbali256 opened this issue Aug 9, 2021 · 2 comments · Fixed by #165
Assignees
@slavek-kucera
Labels
bug Something isn't working released on @release-0.15.0 released

Comments

@michalbali256
Copy link
Contributor

Describe the bug
When calling a macro, all operands should retain their case. However, in current version, label does not.

To Reproduce

      MACRO
&V    CASE
    
      AIF ('&V' EQ 'MixedCase').SKIP
      rubbish
.SKIP ANOP
      MEND
      
MixedCase CASE

The program should not yield an error

Screenshots
image

Platform

  • Editor: Any
  • OS: Any
  • Plugin version: 0.13.0
@slavek-kucera slavek-kucera added the bug Something isn't working label Aug 11, 2021
@slavek-kucera slavek-kucera self-assigned this Aug 16, 2021
slavek-kucera added a commit to slavek-kucera/che-che4z-lsp-for-hlasm that referenced this issue Aug 16, 2021
@slavek-kucera
Keep mixed-case variant of the ordsymbol label and use it in macro ca…
7e5e502 
…lls (fixes eclipse-che4z#155)
@slavek-kucera slavek-kucera linked a pull request Aug 16, 2021 that will close this issue
fix: Preserve mixed-case labels on macro calls #165
Merged
slavek-kucera added a commit that referenced this issue Aug 18, 2021
@slavek-kucera
fix: Preserve mixed-case labels on macro calls (#165)
d8545fe 
fix: Keep mixed-case variant of the ordsymbol label and use it in macro calls (fixes #155)
@github-actions
Copy link

github-actions bot commented Nov 3, 2021

🎉 This issue has been resolved in version 0.15.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Nov 8, 2021

🎉 This issue has been resolved in version 0.15.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slavek-kucera slavek-kucera

Labels
bug Something isn't working released on @release-0.15.0 released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Preserve mixed-case labels on macro calls slavek-kucera/che-che4z-lsp-for-hlasm
2 participants
@michalbali256 @slavek-kucera