fix: Diagnostics lost during JSON serialization #170
Conversation
|
Kudos, SonarCloud Quality Gate passed! |
| @@ -64,7 +112,7 @@ std::pair<semantics::operands_si, semantics::remarks_si> statement_fields_parser | |||
|
|
|||
| diagnostic_consumer_transform add_diag_subst([&field, &add_diag, after_substitution](diagnostic_op diag) { | |||
| if (after_substitution) | |||
| diag.message = "While evaluating the result of substitution '" + field + "' => " + std::move(diag.message); | |||
| diag.message = decorate_message(field, diag.message); | |||
There was a problem hiding this comment.
Do we want to run the sanitizer in the language_server to sanitize all diagnostics? I think there are some more diagnostics that show names of symbols... Although those are probably guaranteed to be 'nice' strings since they were lexed as ordinary symbols, it may be more futureproof solution, if we decide to add different diagnostics in the future.
There was a problem hiding this comment.
Also, there are more occasions where we copy the source code into json messages, see lsp_context::get_macro_documentation, and maybe some other places in lsp_context
There was a problem hiding this comment.
As far as I can tell, the only instance when we may end up including an invalid utf-8 sequences into diagnostics is when the code is generated (e.g. by substitutions).
In all other cases the text should be already sanitized or even parsed.
There was a problem hiding this comment.
Yes you are right, I forgot that we sanitize the source prior to parsing it.
How about values of variables that we send via DAP?
There was a problem hiding this comment.
I'll look into that one... 👍
There was a problem hiding this comment.
yes, so dap variables are affected as well. But we could address that together with other dap issues that need to be solved.
|
🎉 This PR is included in version 0.15.0-beta.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 0.15.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
No description provided.