fix: Remove ALIAS operand parsing limitation #178
Conversation
| if (format.form != processing::processing_form::ASM) | ||
| return false; | ||
|
|
||
| auto i = hlasm_ctx->instruction_map().find(opcode.value); |
There was a problem hiding this comment.
why is this search necessary?
I think that the opcode should be already resolved (regarding opsyn, etc) and opcode.type == instruction_type::ASM && *opcode.value == "ALIAS" should be enough.
There was a problem hiding this comment.
I think OPSYN can complicate things...
There was a problem hiding this comment.
But anyway, instruction_map is not modified by OPSYNs, it just holds all the hlasm instructions. opsyns are held in hlasm_context::opcode_mnemo_.
But I still think that the opcode we are looking at holds resolved instruction, regardless of what was really written on the line.
There was a problem hiding this comment.
ok, I'll do additional testing...
slavek-kucera
force-pushed
the
fix_alias_operands
branch
from
b84f255 to
2f84bbd
Compare
|
Kudos, SonarCloud Quality Gate passed! |
|
🎉 This PR is included in version 0.15.0-beta.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 0.15.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
fixes #157