fix: Data definition grammar is too greedy #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavek-kucera
force-pushed
the
fix_datadef_parsing
branch
from
1fc75d6 to
986f518
Compare
|
Kudos, SonarCloud Quality Gate passed! |
SWETAS04
reviewed
Jan 28, 2022
| return diagnostic_op(diagnostic_severity::error, "D004", "Wrong order of modifiers", range); | ||
| } | ||
| // diagnostic_op diagnostic_op::error_D004(const range& range) | ||
| // { |
There was a problem hiding this comment.
Are we going to keep this commented code ?
There was a problem hiding this comment.
Yes, I'd like to keep it as documentation that those messages existed and optionally that we could reuse them.
|
🎉 This PR is included in version 1.0.0-beta.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.