Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing a kubernetes application into a che workspace #760

Conversation

MichalMaler
Copy link
Contributor

https://issues.jboss.org/browse/RHDEVDOCS-1152

adding content about: "Importing a kubernetes application into a Che workspace"

rewrote this document into .adoc
https://docs.google.com/document/d/1VZJSRh8kFpr5U8R_DDycv-4MgFqzdyZybmCcco_ShUg/edit#

Signed-off-by: Michal Maléř <mmaler@redhat.com>
Better version - ready for PR

Signed-off-by: Michal Maléř <mmaler@redhat.com>
@MichalMaler
Copy link
Contributor Author

It's ready for SME review @slemeur @l0rd

@rkratky @supriya-bharadwaj Can I ask you for a Peer review, please?

Copy link

@rkratky rkratky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slemeur I added a commit with a bunch of fixes. It also addresses your comments.

@rkratky rkratky merged commit e036bd8 into eclipse-che:master Jul 30, 2019
@slemeur
Copy link
Contributor

slemeur commented Jul 30, 2019

Thanks

@l0rd l0rd mentioned this pull request Jul 30, 2019
85 tasks
@MichalMaler MichalMaler deleted the i1152-Importing_a_Kubernetes_application_into_a_Che_workspace branch August 6, 2019 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants