Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent operator removal, while it still has some CR's to manage #13717

Closed
rhopp opened this issue May 29, 2019 · 2 comments
Closed

Prevent operator removal, while it still has some CR's to manage #13717

rhopp opened this issue May 29, 2019 · 2 comments
Assignees
Labels
kind/bug Outline of a bug - must adhere to the bug report template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@rhopp
Copy link
Contributor

rhopp commented May 29, 2019

Currently, when there is a checluster CR with oAuth enabled, it has oauthclients.finalizers.che.eclipse.org finalizer. This means, that this CR is not possible to delete until this finalizer is removed.
This has a good reason: eclipse-che/che-operator#11

But it introduces another problem: When the che-operator is deleted before CR is deleted, this CR remains there and it's not possible to delete it (without some workarounds).
This is mostly notable, when CRW is deployed with Openshift oAuthSupport and user then tries to delete whole namespace, where CRW is deployed (together with the operator) -> everything is deleted, but for the checluster CR, which prevents the namespace from deletion.

I was thinking... couldn't che-operator be aware of how many checluster CRs is it managing and maybe have it's own finalizer if the number is greater than 0? That would mean it would be also impossible to delete che-operator before removing all its managed CRs.

Is something like that possible, @davidfestal ? Or do we have to provide some instructions on how to delete CRW deployment (or maybe some uninstall script)?

@dmytro-ndp
Copy link
Contributor

Command to remove CheCluster custom resource with finalizer:
oc patch checluster codeready -p '{ "metadata": { "finalizers": null }}' --type merge -n ${CHE_OPENSHIFT_PROJECT}

@benoitf benoitf transferred this issue from eclipse-che/che-operator Jul 5, 2019
@benoitf benoitf added kind/bug Outline of a bug - must adhere to the bug report template. target/che7GA labels Jul 5, 2019
@che-bot
Copy link
Contributor

che-bot commented Jan 15, 2020

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

4 participants