Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert golang version to 1.13 #617

Merged
merged 2 commits into from
Jan 11, 2021
Merged

Revert golang version to 1.13 #617

merged 2 commits into from
Jan 11, 2021

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Jan 11, 2021 •
edited
Loading

Signed-off-by: Anatolii Bazko abazko@redhat.com

What does this PR do

  • Reverts golang version from 1.14 to 1.13 (1.14 causes failed build on different platforms)
  • Added github action to check multi-platform build

Reference issue

eclipse-che/che#18768

@tolusha
Improve build check
97c90e7 
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@openshift-ci-robot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@tolusha
Revert go to 1.13
083896c 
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@tolusha tolusha changed the title Improve build check Revert golang version to 1.13 Jan 11, 2021
@tolusha tolusha mentioned this pull request Jan 11, 2021
Closed
79 tasks
@tolusha tolusha marked this pull request as ready for review January 11, 2021 09:59
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AndrienkoAleksandr, mmorhun, tolusha
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tolusha tolusha merged commit 5ae85f9 into master Jan 11, 2021
@tolusha tolusha deleted the test branch January 11, 2021 11:14
nickboldt pushed a commit that referenced this pull request Jan 11, 2021
@tolusha @nickboldt
Revert golang version to 1.13 (#617)
3e3424b 
* Revert golang to 1.13

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@nickboldt
Copy link
Contributor

Also cherrypicked to 7.24.x branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmorhun mmorhun mmorhun approved these changes

@AndrienkoAleksandr AndrienkoAleksandr AndrienkoAleksandr approved these changes

@davidfestal davidfestal Awaiting requested review from davidfestal

@nickboldt nickboldt Awaiting requested review from nickboldt

@flacatus flacatus Awaiting requested review from flacatus

Assignees

@AndrienkoAleksandr AndrienkoAleksandr

@mmorhun mmorhun

Labels
lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tolusha @openshift-ci-robot @nickboldt @AndrienkoAleksandr @mmorhun