Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve way of merging tasks configurations #13754

Closed
RomanNikitenko opened this issue May 24, 2019 · 1 comment
Closed

Improve way of merging tasks configurations #13754

RomanNikitenko opened this issue May 24, 2019 · 1 comment
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/enhancement A feature request - must adhere to the feature request template.

Comments

@RomanNikitenko
Copy link
Member

Description

We support export configurations from devfile in a launch.json and tasks.json files.
The current implementation allows to merge existed configurations from config file and configs from devfile. Configurations from devfile have higher priority than existed configs in config file.
If you already have configs in launch.json file, for example, the configs with the same label will be replaced by configs from devfile.
So, at the moment it's expected that user should edit label/name of a configuration, which he customized.
We can improve the mechanism of merging by adding prefix for configs with the same label/name, but with different content.

@benoitf benoitf transferred this issue from eclipse-che/che-theia Jul 5, 2019
@benoitf benoitf added area/editor/theia Issues related to the che-theia IDE of Che kind/enhancement A feature request - must adhere to the feature request template. labels Jul 5, 2019
@RomanNikitenko
Copy link
Member Author

RomanNikitenko commented Jul 19, 2019

The behavior was improved within eclipse-che/che-theia#355: so the existed configs in config file have higher priority than the configurations from devfile. User can add new configurations to config file or edit existed ones - the changes are stored to config file. We have another issue about the sync of configurations from config file with configs from devfile.
So I'm closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

No branches or pull requests

2 participants