Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update JsonExampleEditorProvider Code Example #1622

Closed
JonasHelming opened this issue Jul 1, 2016 · 4 comments
Closed

Update JsonExampleEditorProvider Code Example #1622

JonasHelming opened this issue Jul 1, 2016 · 4 comments
Assignees
@vparfonov
Labels
kind/enhancement A feature request - must adhere to the feature request template. sprint/current
Milestone
5.0.0-M6

Comments

@JonasHelming
Copy link

https://github.com/eclipse/che/blob/80ae9417866fa61bb6be59b07d0ea77d5167f90d/samples/sample-plugin-json/che-sample-plugin-json-ide/src/main/java/org/eclipse/che/plugin/jsonexample/ide/editor/JsonExampleEditorProvider.java

It can be simplified after introducing the AbstractTextEditorProvider, it must only implement #getEditorConfiguration, now

Update the docu as well...
@JonasHelming JonasHelming mentioned this issue Jul 1, 2016
Closed
@bmicklea bmicklea added the kind/enhancement A feature request - must adhere to the feature request template. label Aug 22, 2016
@bmicklea
Copy link

@JonasHelming are you taking care of this?

@JonasHelming
Copy link
Author

Unfortunately, we do not have time for this at the moment

@slemeur
Copy link
Contributor

slemeur commented Aug 22, 2016

@ashumilova + @vparfonov : could you please give a look on this?

@TylerJewell TylerJewell added team/ide severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code. labels Sep 18, 2016
@TylerJewell
Copy link

Elevating this to a blocker for discussion. This should be a quick, easy fix to make for someone on team/ide team.

@bmicklea bmicklea added sprint/next and removed severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code. labels Sep 27, 2016
@vparfonov vparfonov mentioned this issue Oct 12, 2016
Merged
@vparfonov vparfonov added this to the 5.0.0-M6 milestone Oct 12, 2016
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vparfonov vparfonov

Labels
kind/enhancement A feature request - must adhere to the feature request template. sprint/current
Projects
None yet
Milestone
5.0.0-M6
Development

No branches or pull requests
5 participants
@TylerJewell @JonasHelming @vparfonov @slemeur @bmicklea