Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Depending on che flavor, use the the right image puller image for the deployment as part of che-operator #18569

Closed
ibuziuk opened this issue Dec 9, 2020 · 2 comments
Closed

Depending on che flavor, use the the right image puller image for the deployment as part of che-operator #18569

ibuziuk opened this issue Dec 9, 2020 · 2 comments
Assignees
@tomgeorge
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator area/image-puller Issues related to image-puller https://github.com/che-incubator/kubernetes-image-puller kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.
Milestone
7.25

Comments

@ibuziuk
Copy link
Member

ibuziuk commented Dec 9, 2020 •
edited
Loading

Based on discussions in eclipse-che/che-operator#541, we should choose the correct image puller image based on Che flavor. this can be done via an additional field in the ConfigMap, or by injecting an environment variable into the deployment.

It is not 100% clear why we can not use the upstream UBI base image / also some related discussion - #17742
@ibuziuk ibuziuk added kind/task Internal things, technical debt, and to-do tasks to be performed. area/image-puller Issues related to image-puller https://github.com/che-incubator/kubernetes-image-puller area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator severity/P1 Has a major impact to usage or development of the system. team/hosted-che labels Dec 9, 2020
@ibuziuk ibuziuk added this to the 7.24 milestone Dec 9, 2020
@ibuziuk ibuziuk mentioned this issue Dec 9, 2020
Closed
@tomgeorge tomgeorge self-assigned this Dec 9, 2020
@tomgeorge tomgeorge mentioned this issue Dec 9, 2020
Closed
@gattytto gattytto mentioned this issue Dec 10, 2020
Closed
@gattytto
Copy link

gattytto commented Dec 10, 2020 •
edited
Loading

@ibuziuk could there be a imagePullerImage attribute in the che crd and the che-image-puller-crd to customize this value from a chectl operator patch yaml?

also the image values for both standard possibilities(che and codeready) could be updated with auto-pr's from dependabot-like auto-updates? I see it is a constant in the puller operator .go code now.

@gattytto gattytto mentioned this issue Dec 10, 2020
Closed
18 tasks
@nickboldt nickboldt modified the milestones: 7.24, 7.25 Jan 8, 2021
This was referenced Jan 12, 2021
Closed
Merged
@ibuziuk
Copy link
Member Author

ibuziuk commented Jan 19, 2021

@gattytto there is a separate issue for supporting image puller in chectl - #18570
Also, we are going to close this issue since currently we do not plan to support cheFlavour in image puller and leave it as is as a community supported component

@ibuziuk ibuziuk closed this as completed Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomgeorge tomgeorge

Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator area/image-puller Issues related to image-puller https://github.com/che-incubator/kubernetes-image-puller kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Milestone
7.25
Development

No branches or pull requests
4 participants
@nickboldt @gattytto @tomgeorge @ibuziuk