Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generates devfile v2 entries in addition to meta.yaml entries generated from che-editors/che-plugins yaml files #19060

Closed
benoitf opened this issue Feb 12, 2021 · 2 comments · Fixed by eclipse-che/che-plugin-registry#853
Labels
area/devfile-spec Issues related to Devfile v2 area/plugin-registry kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.

Comments

@benoitf
Copy link
Contributor

benoitf commented Feb 12, 2021

Is your task related to a problem? Please describe.

plugin-broker is consuming for now meta.yaml from the plug-in registry.
With devfile 2, consumers won't be able to consume 'meta.yaml' format.
As we have a central/pivot format, we can generate both meta.yaml and devfile v2 entries

Describe the solution you'd like

generate devfile entries from che-editors.yaml and che-plugins.yaml files

Describe alternatives you've considered

step2: could convert the che-editors.yaml and che-plugins.yaml to be devfile 2.0 objects (and still generate meta.yaml/devfile.yaml)

Additional context

There is some limitation on devfile 2.0 consumer like dev workspace operator, s:

  1. it shouldn't generate entries with secure/true
  2. 127.0.0.1 listening is not supported so it should be mapped to 0.0.0.0

cc @sleshchenko please provide any input about current limitations that I've not listed

@benoitf benoitf added kind/task Internal things, technical debt, and to-do tasks to be performed. area/plugin-registry area/devfile-spec Issues related to Devfile v2 labels Feb 12, 2021
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Feb 12, 2021
@yhontyk yhontyk added severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Feb 12, 2021
@sleshchenko
Copy link
Member

sleshchenko commented Feb 12, 2021

If I'm not mistaken, currently Che Plugin Broker overrides plugins entrypoint to use remote-runtime binary, with devworkspace and devfile, that's plugin registry who should provision that stuff into plugin's definition.

^ Seems I'm wrong and sidecar defines entrypoints and expects PLUGIN_REMOTE_ENDPOINT_EXECUTABLE env var to be injected https://github.com/eclipse/che-plugin-registry/blob/master/sidecars/java/Dockerfile#L32
but devWorkspace is not going to set this value. So, plugin registry should care about it, or somebody else on the workspace start chain

@benoitf
Copy link
Contributor Author

benoitf commented Feb 16, 2021

@sleshchenko good question/feedback. Will need to think on who will set that variable. Probably che-theia that will take care of plug-ins as value is defined in che theia current meta.yaml definition

But management of theia plug-ins is for milestone 2 (so still some time to think about it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devfile-spec Issues related to Devfile v2 area/plugin-registry kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
4 participants