[devworkspace-che-operator] A failed workspace routing is not finalized

[metlos]

Is your enhancement related to a problem? Please describe.

When there is a failed devworkspace (with che routingClass) with a workspace routing in the "Failed" phase, the routing is not cleaned up upon deleting the devworkspace object.

Describe the solution you'd like

The devworkspace che operator should correctly process the workspace routing and clean up the finalizer so that the routing can be properly deleted along with the owning devworkspace object.

Describe the bug

When there is a failed devworkspace (with che routingClass) with a workspace routing in the "Failed" phase, the routing is not cleaned up upon deleting the devworkspace object.

Che version

devworkspace-operator master + devworkspace-che-operator master

Steps to reproduce

1. Create 2 chemanager objects in the cluster
2. Apply the sample workspace from the devworkspace-che-operator repo
3. run kubectl delete devworkspace theia-nodejs

Expected behavior

The delete completes successfully and there is no workspacerouting object in the namespace where the devworkspace object was deployed.

Runtime

• minikube (minikube version: v1.17.1, Client Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.3", GitCommit:"2e7996e3e2712684bc73f0dec0200d64eec7fe40", GitTreeState:"clean", BuildDate:"2020-05-20T12:52:00Z", GoVersion:"go1.13.9", Compiler:"gc", Platform:"linux/amd64"}
  Server Version: version.Info{Major:"1", Minor:"20", GitVersion:"v1.20.2", GitCommit:"faecb196815e248d3ecfb03c680a4507229c2a56", GitTreeState:"clean", BuildDate:"2021-01-13T13:20:00Z", GoVersion:"go1.15.5", Compiler:"gc", Platform:"linux/amd64"}
  )

Installation method

Manual

Environment

my computer, linux

[metlos]

All PRs related to this problem are merged, closing.