Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve vscode-extensions builder to work independently of extension.json changes #19134

Closed
ericwill opened this issue Feb 23, 2021 · 0 comments · Fixed by redhat-developer/devspaces-vscode-extensions#20
Closed

Improve vscode-extensions builder to work independently of extension.json changes #19134

ericwill opened this issue Feb 23, 2021 · 0 comments · Fixed by redhat-developer/devspaces-vscode-extensions#20
Assignees
@ericwill
Labels
area/plugins kind/enhancement A feature request - must adhere to the feature request template. kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P2 Has a minor but important impact to the usage or development of the system. sprint/current
Milestone
7.28

Comments

@ericwill
Copy link
Contributor

Is your task related to a problem? Please describe.

In the codeready-workspaces-vscode-extensions repo, we have a system to build vscode-extensions inside a UBI8 container: https://github.com/redhat-developer/codeready-workspaces-vscode-extensions/blob/main/.ci/extension_build_publish.sh#L20

This build system is only triggered on changes to extensions.json in any given file, which isn't nice when a Dockerfile needs to be tweaked.

Describe the solution you'd like

Adjust the CI script to look for an extensions.json file even if it's not in the subject of changes

Describe alternatives you've considered

N/A

Additional context

N/A
@ericwill ericwill added kind/enhancement A feature request - must adhere to the feature request template. kind/task Internal things, technical debt, and to-do tasks to be performed. area/plugins labels Feb 23, 2021
@ericwill ericwill added this to the 7.28 milestone Feb 23, 2021
@ericwill ericwill self-assigned this Feb 23, 2021
@benoitf benoitf added the severity/P2 Has a minor but important impact to the usage or development of the system. label Feb 24, 2021
@ericwill ericwill mentioned this issue Feb 25, 2021
Closed
46 tasks
This was referenced Mar 18, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericwill ericwill

Labels
area/plugins kind/enhancement A feature request - must adhere to the feature request template. kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P2 Has a minor but important impact to the usage or development of the system. sprint/current
Projects
None yet
Milestone
7.28
Development

Successfully merging a pull request may close this issue.

Build CI Improvements ericwill/codeready-workspaces-vscode-extensions
2 participants
@benoitf @ericwill