Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[devworkspace-che] Build consolidation #19286

Closed
metlos opened this issue Mar 15, 2021 · 0 comments
Closed

[devworkspace-che] Build consolidation #19286

metlos opened this issue Mar 15, 2021 · 0 comments
Labels
engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. kind/enhancement A feature request - must adhere to the feature request template. status/in-progress This issue has been taken by an engineer and is under active development.
Milestone

Comments

@metlos
Copy link
Contributor

metlos commented Mar 15, 2021

Is your enhancement related to a problem? Please describe.

make install installs the CRD, while you probably want make deploy which deploys the built operator to the cluster (but doesn't install the CRDs)

We use IMG, NAMESPACE and other generically named env vars to influence the results of the various build targets. This can cause trouble when one works on multiple projects with similar naming conventions and exports one of those envvars - if one is not careful, one can overwrite build results of one project with the results of the other.

When run locally, the operator runs with the default kube context, meaning that most of the time the permissions used by the operator are much higher than they would be at the actual runtime in the cluster.

Describe the solution you'd like

Try to improve the build to be more consistent, safe to use and local runs more similar to the actual runtime conditions.

Additional context

This is for the https://github.com/che-incubator/devworkspace-che-operator

@metlos metlos added kind/enhancement A feature request - must adhere to the feature request template. status/in-progress This issue has been taken by an engineer and is under active development. team/platform engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. labels Mar 15, 2021
@skabashnyuk skabashnyuk added this to the 7.28 milestone Mar 15, 2021
@metlos metlos closed this as completed Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. kind/enhancement A feature request - must adhere to the feature request template. status/in-progress This issue has been taken by an engineer and is under active development.
Projects
None yet
Development

No branches or pull requests

2 participants