Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trying to stop a DevWorkspace make it restart #19369

Closed
1 of 23 tasks
benoitf opened this issue Mar 23, 2021 · 6 comments
Closed
1 of 23 tasks

Trying to stop a DevWorkspace make it restart #19369

benoitf opened this issue Mar 23, 2021 · 6 comments
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Milestone
7.29

Comments

@benoitf
Copy link
Contributor

benoitf commented Mar 23, 2021

Describe the bug

Apply spec: started : false and workspace is not stopped but restarted.

Che version

  • latest
  • nightly
  • other: please specify

Steps to reproduce

Start a DevWorkspace using Eclipse Che
Edit DW and replace 'spec/started: true' by false

It restarts my workspace

u4hNYX7t1x.mp4

Expected behavior

Workspace is stopped

Runtime

  • kubernetes (include output of kubectl version)
  • Openshift (include output of oc version)
  • minikube (include output of minikube version and kubectl version)
  • minishift (include output of minishift version and oc version)
  • docker-desktop + K8S (include output of docker version and kubectl version)
  • other: (please specify)

Screenshots

Installation method

  • chectl
    • provide a full command that was used to deploy Eclipse Che (including the output)
    • provide an output of chectl version command
  • OperatorHub
  • I don't know

Environment

  • my computer
    • Windows
    • Linux
    • macOS
  • Cloud
    • Amazon
    • Azure
    • GCE
    • other (please specify)
  • Dev Sandbox (workspaces.openshift.com)
  • other: please specify

Eclipse Che Logs

Additional context
@benoitf benoitf added kind/bug Outline of a bug - must adhere to the bug report template. engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. labels Mar 23, 2021
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Mar 23, 2021
@sleshchenko
Copy link
Member

It should be cherry-picked into 7.28.x (DWO 0.2.x) if it's not done before release.

@vzhukovs vzhukovs added severity/P1 Has a major impact to usage or development of the system. area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Mar 23, 2021
@sleshchenko sleshchenko mentioned this issue Mar 25, 2021
Closed
30 tasks
@sleshchenko sleshchenko added this to the 7.29 milestone Mar 25, 2021
@sleshchenko
Copy link
Member

I think would be great if we back-ported it to 7.28.x

@amisevsk
Copy link
Contributor

Does not reproduce for workspaces created manually (i.e. no Che running).

@dmytro-ndp
Copy link
Contributor

dmytro-ndp commented Mar 25, 2021 •
edited
Loading

@benoitf, @amisevsk, @sleshchenko: the issue is duplicating #19379 and had already been fixed by eclipse-che/che-dashboard#193 in Eclipse Che 7.28.0

@sleshchenko
Copy link
Member

@dmytro-ndp thanks for hint.
I'll try DevWorkspace created by Che and make sure it works.

@benoitf
Copy link
Contributor Author

benoitf commented Mar 30, 2021

workspace is now stopped (and pods removed)

NAMESPACE   NAME               WORKSPACE ID                PHASE     INFO
user1-che   spring-petclinic   workspaceea5ac4ddc8354c9e   Stopped   Stopped

@benoitf benoitf closed this as completed Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Milestone
7.29
Development

No branches or pull requests
7 participants
@benoitf @dmytro-ndp @tolusha @vzhukovs @sleshchenko @amisevsk @che-bot