Unexpected restart workspace when it is stopping from opened IDE

[artaleks9]

Describe the bug

• I faced out with a problem inexpected rerun workspace when it is stopping from opened IDE. It is reproducing in the E2E test - running workspace is stopping via API in opened IDE, but workspace is not stopped, and it is rerun.

Che version

• nightly

Steps to reproduce

1. Workspace is running and IDE is opened
2. Try to stop workspace somehow (in my case it is doing via API in the E2E test)
3. Workspace is restarting

Expected behavior

• Workspace should be stopped

Runtime

• Openshift (include output of oc version)
• minikube (include output of minikube version and kubectl version)

Screenshots

Installation method

• chectl

Additional context

Logs of launching E2E test show that in the beginning status of workspace is 'STOPPING' and then becomes 'STARTING'.

09:04:51  RequestHandler response:
09:04:51   { status: 200,
09:04:51    statusText: '',
09:04:51    headers:
09:04:51     { server: 'nginx/1.15.9',
09:04:51       date: 'Wed, 24 Mar 2021 07:04:51 GMT',
09:04:51       'content-type': 'application/json',
09:04:51       'transfer-encoding': 'chunked',
09:04:51       connection: 'close',
09:04:51       vary: 'Accept-Encoding',
09:04:51       'cache-control': 'public, no-cache, no-store, no-transform',
09:04:51       etag: '"41f1bd36f4526699b3959c76c06ea52d"' },
09:04:51    config:
09:04:51     { url:
09:04:51        'https://che-eclipse-che.10.0.206.106.nip.io/api/workspace/workspaceefet7875j52z6hgi',
09:04:51       method: 'get',
09:04:51       headers:
09:04:51        { Accept: 'application/json, text/plain, */*',
09:04:51          Authorization: 'CENSORED',
09:04:51          'User-Agent': 'axios/0.21.1' },
09:04:51       transformRequest: [ null ],
09:04:51       transformResponse: [ null ],
09:04:51       timeout: 0,
09:04:51       xsrfCookieName: 'XSRF-TOKEN',
09:04:51       xsrfHeaderName: 'X-XSRF-TOKEN',
09:04:51       maxContentLength: -1,
09:04:51       maxBodyLength: -1 },
09:04:51    request: 'CENSORED',
09:04:51    data:
09:04:51     { links:
09:04:51        { self:
09:04:51           'https://che-eclipse-che.10.0.206.106.nip.io/api/workspace/workspaceefet7875j52z6hgi',
09:04:51          ide:
09:04:51           'https://che-eclipse-che.10.0.206.106.nip.io/admin/checkGeneratingSsh',
09:04:51          'environment/statusChannel': 'wss://che-eclipse-che.10.0.206.106.nip.io/api/websocket',
09:04:51          'environment/outputChannel': 'ws://che-host.eclipse-che.svc:8080/api/websocket' },
09:04:51       attributes:
09:04:51        { 'org.eclipse.che.runtimes_id': 'runtimeskpw54o7od6qpnhe9',
09:04:51          infrastructureNamespace: 'admin-che',
09:04:51          stopped: '1616569490625',
09:04:51          created: '1616569320809',
09:04:51          stoppedAbnormally: 'false',
09:04:51          updated: '1616569324023' },
09:04:51       namespace: 'admin',
09:04:51       temporary: false,
09:04:51       id: 'workspaceefet7875j52z6hgi',
09:04:51       status: 'STOPPING',
09:04:51       runtime:
09:04:51        { machines: [Object],
09:04:51          machineToken:

----

09:05:13  RequestHandler request:
09:05:13   { url:
09:05:13     'https://che-eclipse-che.10.0.206.106.nip.io/api/workspace/workspaceefet7875j52z6hgi',
09:05:13    method: 'get',
09:05:13    headers:
09:05:13     { common: { Accept: 'application/json, text/plain, */*' },
09:05:13       delete: {},
09:05:13       get: {},
09:05:13       head: {},
09:05:13       post: { 'Content-Type': 'application/x-www-form-urlencoded' },
09:05:13       put: { 'Content-Type': 'application/x-www-form-urlencoded' },
09:05:13       patch: { 'Content-Type': 'application/x-www-form-urlencoded' },
09:05:13       Authorization: 'CENSORED' },
09:05:13    transformRequest: [ null ],
09:05:13    transformResponse: [ null ],
09:05:13    timeout: 0,
09:05:13    xsrfCookieName: 'XSRF-TOKEN',
09:05:13    xsrfHeaderName: 'X-XSRF-TOKEN',
09:05:13    maxContentLength: -1,
09:05:13    maxBodyLength: -1 }
09:05:13  RequestHandler response:
09:05:13   { status: 200,
09:05:13    statusText: '',
09:05:13    headers:
09:05:13     { server: 'nginx/1.15.9',
09:05:13       date: 'Wed, 24 Mar 2021 07:05:13 GMT',
09:05:13       'content-type': 'application/json',
09:05:13       'transfer-encoding': 'chunked',
09:05:13       connection: 'close',
09:05:13       vary: 'Accept-Encoding',
09:05:13       'cache-control': 'public, no-cache, no-store, no-transform',
09:05:13       etag: '"3a769b64eeae864efad74dc691aa5331"' },
09:05:13    config:
09:05:13     { url:
09:05:13        'https://che-eclipse-che.10.0.206.106.nip.io/api/workspace/workspaceefet7875j52z6hgi',
09:05:13       method: 'get',
09:05:13       headers:
09:05:13        { Accept: 'application/json, text/plain, */*',
09:05:13          Authorization: 'CENSORED',
09:05:13          'User-Agent': 'axios/0.21.1' },
09:05:13       transformRequest: [ null ],
09:05:13       transformResponse: [ null ],
09:05:13       timeout: 0,
09:05:13       xsrfCookieName: 'XSRF-TOKEN',
09:05:13       xsrfHeaderName: 'X-XSRF-TOKEN',
09:05:13       maxContentLength: -1,
09:05:13       maxBodyLength: -1 },
09:05:13    request: 'CENSORED',
09:05:13    data:
09:05:13     { links:
09:05:13        { self:
09:05:13           'https://che-eclipse-che.10.0.206.106.nip.io/api/workspace/workspaceefet7875j52z6hgi',
09:05:13          ide:
09:05:13           'https://che-eclipse-che.10.0.206.106.nip.io/admin/checkGeneratingSsh',
09:05:13          'environment/statusChannel': 'wss://che-eclipse-che.10.0.206.106.nip.io/api/websocket',
09:05:13          'environment/outputChannel': 'ws://che-host.eclipse-che.svc:8080/api/websocket' },
09:05:13       attributes:
09:05:13        { 'org.eclipse.che.runtimes_id': 'runtimeskpw54o7od6qpnhe9',
09:05:13          infrastructureNamespace: 'admin-che',
09:05:13          stopped: '1616569490625',
09:05:13          created: '1616569320809',
09:05:13          stoppedAbnormally: 'false',
09:05:13          updated: '1616569491618' },
09:05:13       namespace: 'admin',
09:05:13       temporary: false,
09:05:13       id: 'workspaceefet7875j52z6hgi',
09:05:13       status: 'STARTING',
09:05:13       runtime:
09:05:13        { machineToken:
09:05:13           'eyJhbGciOiJSUzI1NiIsImtpbmQiOiJtYWNoaW5lX3Rva2VuIiwia2lkIjoid29ya3NwYWNlZWZldDc4NzVqNTJ6NmhnaSJ9.eyJ3c2lkIjoid29ya3NwYWNlZWZldDc4NzVqNTJ6NmhnaSIsInVpZCI6IjM5ODMwYzk5LWYzZTEtNGI1Mi1iYjhmLTNjZTg5N2U2YTQ0OCIsImF1ZCI6IndvcmtzcGFjZWVmZXQ3ODc1ajUyejZoZ2kiLCJuYmYiOi0xLCJ1bmFtZSI6ImFkbWluIiwiaXNzIjoid3NtYXN0ZXIiLCJleHAiOjE2NDgxMDU0OTEsImlhdCI6MTYxNjU2OTQ5MSwianRpIjoiZTQ2Mzk2NTEtZjBmZC00MGNmLWFlOWItYTlhMWQyZTIwMDRiIn0.VbwmM5E_riF_jxoSjfyyW6AOtt_334zWztcAIuYncKZzlnnmzc8Goikww_Ny1DdPyez0x7xHoZNBh9AIwpVIRVEOwDqEpBuBqdq-tGjnQ12BkmXVCS2N1NRV8WPJH2vIT8Bz2GpQokbDejPiwD1rVPRrpvAj8gcfeNvqDlgGzQjRnVeWQrzgFT1iYVC8EMUeRe9GT6NRCyxizuvziKoZHBvL4HOEHQnNGWYHBIY0vb9shi1pqUWyPG3EKliTsbbbSM8cFWKXxjjD-btagwKjmd8RltRjC3hbYvVcqTkVoajH5F07Jfg9y4pZwmI4K9pM_cTQGGRbM2crD4eXO3FhnA' },
09:05:13       devfile: { metadata: [Object], apiVersion: '1.0.0' } } }
09:05:13              ‣ DriverHelper.wait (1000 milliseconds)
09:05:14  Stopping workspace failed. URL used: api/workspace/workspaceefet7875j52z6hgi

[sleshchenko]

Setting blocker since it break stopping by inactivity and we expect quick fix to be a bit later today merged.