Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use specific command name instead of generic init-container-command in plugin-registry devfiles #19495

Closed
benoitf opened this issue Apr 2, 2021 · 1 comment
Closed

Use specific command name instead of generic init-container-command in plugin-registry devfiles #19495

benoitf opened this issue Apr 2, 2021 · 1 comment
Labels
area/plugin-registry kind/enhancement A feature request - must adhere to the feature request template. severity/P2 Has a minor but important impact to the usage or development of the system.

Comments

@benoitf
Copy link
Contributor

benoitf commented Apr 2, 2021

Is your enhancement related to a problem? Please describe.

Today, plugin-registry is generating from meta.yaml files devfile.yaml but they all have init-container-command as command name. So there is high risk of conflict.

Describe the solution you'd like

We should generate specific name like init-remote-runtime-injector instead of the same name

Describe alternatives you've considered

make specific command when #19034 is implemented

Additional context
@benoitf benoitf added kind/enhancement A feature request - must adhere to the feature request template. severity/P2 Has a minor but important impact to the usage or development of the system. area/plugin-registry labels Apr 2, 2021
@benoitf benoitf mentioned this issue Apr 7, 2021
Merged
9 tasks
@benoitf
Copy link
Contributor Author

benoitf commented Apr 20, 2021

fixed by eclipse-che/che-plugin-registry#914

@benoitf benoitf closed this as completed Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/plugin-registry kind/enhancement A feature request - must adhere to the feature request template. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@benoitf