Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt DevWorkspace Che operator to routingSuffix removal from DevWorkspaceRouting CR #19631

Closed
sleshchenko opened this issue Apr 20, 2021 · 1 comment
Closed

Adapt DevWorkspace Che operator to routingSuffix removal from DevWorkspaceRouting CR #19631

sleshchenko opened this issue Apr 20, 2021 · 1 comment
Labels
engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.
Milestone
7.31

Comments

@sleshchenko
Copy link
Member

Is your task related to a problem? Please describe.

Adapt DevWorkspace Che operator to routingSuffix removal from DevWorkspaceRouting CR.

I tried to adapt but I failed since DWCO depends on it for routings which don't support proxying.

https://github.com/che-incubator/devworkspace-che-operator/compare/main...sleshchenko:tryGetRidOfDWRRoutingSuffix?expand=1#diff-0fd3a3a1441074ca1851c0c11794ad5d422d7747ec0d4448b871e13f387b9347L254

So, DWCO instead of relying on DWO configuration, should have itown config for K8s, and evaluate it on its side on OpenShift, like BasicRouting does. See the corresponding PR on DWCO side:
devfile/devworkspace-operator#391
@sleshchenko sleshchenko added kind/task Internal things, technical debt, and to-do tasks to be performed. engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. team/controller labels Apr 20, 2021
This was referenced Apr 20, 2021
Merged
Merged
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Apr 20, 2021
@azatsarynnyy azatsarynnyy added severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Apr 20, 2021
@skabashnyuk skabashnyuk mentioned this issue May 5, 2021
Closed
13 tasks
@skabashnyuk skabashnyuk added this to the 7.31 milestone May 5, 2021
@sleshchenko sleshchenko mentioned this issue May 11, 2021
Closed
@xbaran4 xbaran4 mentioned this issue May 17, 2021
Merged
@sleshchenko
Copy link
Member Author

is fixed by che-incubator/devworkspace-che-operator#45

@metlos metlos mentioned this issue May 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Milestone
7.31
Development

No branches or pull requests
4 participants
@skabashnyuk @azatsarynnyy @sleshchenko @che-bot